Use glTFLib as a backend #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doerge
reviewed
Jan 30, 2021
|
I opened a small PR against the Khronos repo to get it to work on OS X, but then I also got it working here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24
Resolves #18
This is a larger PR but most was copied/modified from the old RootModel/Buffer classes. glTFLib does a good job fixing validator errors and makes the saving easier. On the other hand writing out the data isn't as clean. The code path for the binary mode vs text is a bit messier. I tried not to break any of the old features with these changes. I made two helper classes to do the conversion for objects and materials. This should make maintaining those a bit easier.
I also did some changes for #22. You can have multiple binary chunks talked about here in the spec but it doesn't fix the alignment issue. I got around those errors by just using zero padding. This keeps everything 4 byte aligned and the validator from complaining. That same section in the spec says to do this.