Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple buffers in binary mode #22

Open
Doerge opened this issue Jan 20, 2021 · 0 comments
Open

Use multiple buffers in binary mode #22

Doerge opened this issue Jan 20, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Doerge
Copy link
Collaborator

Doerge commented Jan 20, 2021

The current implementation dumps all buffers into one big blob of a buffer, and then uses views with offsets to discern the different data.
It looks like it might be valid to use multiple binary buffers instead.

The implications of having used just one buffer are a bit unclear. Maybe this validation error in binary-nonedraco-mode is related:

            {
                "code": "ACCESSOR_TOTAL_OFFSET_ALIGNMENT",
                "message": "Accessor's total byteOffset 397965 isn't a multiple of componentType length 4.",
                "severity": 0,
                "pointer": "/accessors/0"
            },
@Doerge Doerge changed the title Maybe use multiple buffers in binary mode Use multiple buffers in binary mode Jan 25, 2021
@Doerge Doerge added the enhancement New feature or request label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant