Migrate to PostgreSQL #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbdlin
reviewed
Feb 14, 2024
| @@ -4,7 +4,7 @@ services: | |||
| build: . | |||
| container_name: plugin_store | |||
| environment: | |||
| - DB_PATH=/app/.database/plugin_store_new.db | |||
| - DB_URL | |||
There was a problem hiding this comment.
We probably want this DB_URL specified for local dev, as the postgres instance starts in the same dockerfile anyway.
| @@ -4,26 +4,32 @@ services: | |||
| build: . | |||
| container_name: "${DEPLOYMENT_NAME}" | |||
| environment: | |||
| - DB_PATH | |||
| - DB_URL | |||
There was a problem hiding this comment.
Actually, same here. We can build it from POSTGRES_PASSWORD to not have it hardcoded here.
| def db_sessionmaker(db_engine): | ||
| return sessionmaker(bind=db_engine, autoflush=False, future=True, expire_on_commit=False, class_=AsyncSession) | ||
| @pytest.fixture(scope="session") | ||
| def seed_db_sessionmaker(seed_db_engine: tuple["AsyncEngine", "sessionmaker"]) -> "sessionmaker": |
There was a problem hiding this comment.
We don't have unseed DB anymore, we can drop seed from names everywhere.
for data migration: .dump the sqlite, edit the .sql to remove everything but the BEGIN TRANSACTION, INSERTs, and COMMIT, then edit it to look like this SET session_replication_role = 'replica'; -- Hack to make type checking more lenient, changed back later update pg_cast set castcontext='a' where casttarget = 'boolean'::regtype; -- Hack to allow int to boolean conversion, changed back later BEGIN TRANSACTION; tons of inserts COMMIT; update pg_cast set castcontext='e' where casttarget = 'boolean'::regtype; SET session_replication_role = 'origin'; then run migrations via the makefile on a new postgres db and then load the sql in
Tests were failing due to wrong default ordering of plugins being checked by them.
Pytest freezegun is no longer maintained, switched to a fork. Also bumped pytest-asyncio due to inability to use async fixtures in other scopes than `function` in older version.
Fixed black, isort and mypy failing
Seeder (FakePluginGenerator) no longer uses logic from Database class nor the time freezer for seeding the database.
Make use of DB transactions to rollback tests back to the original state instead of recreating DB on each test.
gbdlin
force-pushed
the
postgresql
branch
2 times, most recently
from
8265022
to
8b0423f
Compare
|
we should really merge this already |
`pull_request` trigger needs some more work to be functional. Reverting back to `pull_request_target` for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.