Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Update: Junk-Store #669

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ebenbruyns
Copy link
Contributor

@ebenbruyns ebenbruyns commented Aug 8, 2024

Junk-Store

Fix an issue with configs not being created properly

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@ebenbruyns ebenbruyns requested a review from a team as a code owner August 8, 2024 02:57
@mrsjunkrunner
Copy link

Tested on the following channel set-ups:

Steam Deck:
Decky version: v3.0.1
OS: Steam OS v3.5.9

  • [ x ] Steam OS Beta & Decky Pre-release
  • [ x ] Steam OS Beta & Decky Stable
  • [ x ] Steam OS Stable & Decky Testing/Pre-release
  • [ x ] Steam OS Stable & Decky Stable

Laptop running Arch Linux:
OS: Arch Linux
Decky: v3.0.1

  • [ x ] Steam OS Beta & Decky Pre-release
  • [ x ] Steam OS Beta & Decky Stable
  • [ x ] Steam OS Stable & Decky Testing/Pre-release
  • [ x ] Steam OS Stable & Decky Stable

A) Any major blocking issues that you encountered, if any.
None

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
None

C) A list of currently installed plugins (Name and version preferred)

  • Junk-Store v1.1.8pre-fb9f702
  • Wine Cellar: v0.1.5-c1e664b

D) Yay/nay on to send to the production store or if it requires more testing.
It has had extensive testing over the course of the past month downloading and running various games using the different features. I have successfully installed/uninstalled Epic games, run games from exe menu, repaired games, enabled anti cheat features, used the EOS overlay function, and more. I have encountered no issues between using this version on my laptop or on my Steam Deck.

Yes, it is ready to push to the production store.

@ebenbruyns
Copy link
Contributor Author

Merge when you guys have time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

4 participants