Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MicroSDeck Version #577

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

CEbbinghaus
Copy link
Contributor

@CEbbinghaus CEbbinghaus commented Mar 15, 2024

MicroSDeck

Overhauled backend with lots of features and optimizations including:

  • New Greatly improved UI
  • The ability to add / remove non steam games
  • Interactive Documentation
    just to name the big 3

Checklist:

  • Complete documentation
  • Small bugfixes and performance improvements

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Preview Update Channel.

@CEbbinghaus
Copy link
Contributor Author

I did test on the preview channel although this was a long enough time ago that I would probably consider it not valid for these purposes. Also this PR has been raised early to allow for people to try the plugin in the testing store before it is finalized. A few more changes need to happen for this plugin to be updated to V1.0.0 and merged

@CEbbinghaus
Copy link
Contributor Author

can someone greenlight this to release it on the testing store?

Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfect on SteamOS stable, Beat and Preview Update Channel.

@CEbbinghaus
Copy link
Contributor Author

Reminder that the PR is NOT yet ready to merge. BUT it should be published to the testing store so users can try it out. A version bump is required before the PR can be merged.

Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, no more 2000 billions line added :P
Good for testing in my book.

@CEbbinghaus
Copy link
Contributor Author

No 2000 lines, promise. All that is left to do is figure out the problem with the version & finish the documentation.

@CEbbinghaus
Copy link
Contributor Author

Finally got around to pushing the fix that should ideally remove the wierd 0.0.0 version from the testing store. Can someone reapprove the Actions run so I can verify that the problem is fixed?

Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes since last review look fine

@TrainDoctor
Copy link
Member

@CEbbinghaus, looking for confirmation from you that this is working on latest SteamOS Stable, once you can confirm that I can mark the plugin as ready for testing and will then try to summon testers as best I can. Thanks.

@TrainDoctor TrainDoctor requested review from a team August 1, 2024 00:08
@CEbbinghaus
Copy link
Contributor Author

I will test. Need to merge my documentation, Sorry I have been so busy its been really hectic IRL with family illness and having to move.

Will try to get to it soon as possible. Sorry for all the delays 😥

@TrainDoctor
Copy link
Member

I will test. Need to merge my documentation, Sorry I have been so busy its been really hectic IRL with family illness and having to move.

Will try to get to it soon as possible. Sorry for all the delays 😥

Totally understand, and don't stress about it to much. Life comes fast and without warning. Take the time that you need. I'm basically just pulse checking everything to help making my life maintaining the plugin db easier.

Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfect on SteamOS Stable/ Beta an Preview Update Channel.

@TrainDoctor
Copy link
Member

Tested and works perfect on SteamOS Stable/ Beta an Preview Update Channel.

@CEbbinghaus I noticed your tasklist is not complete, if @nabel0 gives the latest version a test and confirms it's working is this good to merge? I don't want to put this out unfinished.

@CEbbinghaus
Copy link
Contributor Author

Not quite yet sorry. Its getting very close but the tasklist is still not fully actioned. Going to try and finish it over the weekend

@CEbbinghaus
Copy link
Contributor Author

I have made some good progress towards completing the plugin. Lots of small improvements. I will likely need a little help with my python script which is not nearly as reliable at keeping the backend running as I would like. Documentation is getting there but probably the slowest of all the things I have to do (not great at writing docs).

So there has been progress but we aren't quite there yet (sorry)

Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfect on SteamOS Stable/ Beta an Preview Update Channel.

@CEbbinghaus
Copy link
Contributor Author

We are getting close. At this point it is basically just the Docs, some QOL & bugfixes and lastly the version update. Most of the big boxes have been ticked

@TrainDoctor
Copy link
Member

We are getting close. At this point it is basically just the Docs, some QOL & bugfixes and lastly the version update. Most of the big boxes have been ticked

Understood. If nabelo can come in and confirm that on the final commit where you feel ready to go then we're good to go at that point.

@CEbbinghaus
Copy link
Contributor Author

Much appreciated. Sorry it's taken so long

@CEbbinghaus
Copy link
Contributor Author

Pushed an update which fixes the build error. It just pins the docker container to the last good version while I figure out what is causing the build failure

@CEbbinghaus
Copy link
Contributor Author

CEbbinghaus commented Sep 28, 2024

I'm starting to think that it may be smarter to just merge incrementally. Get a <1.0 version into master and just keep updating as the versions come in. It doesn't make sense gating all of this work behind documentation & other 1.0 tasks (including licensing & setting up code of conduct, etc...)

@TrainDoctor You happy with that?

(I'll add one update to at least add something into the docs but that is still a ways away from 1.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

5 participants