-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Config structs according to features #800
Open
CPerezz
wants to merge
7
commits into
Spotifyd:master
Choose a base branch
from
CPerezz:cfgd_sharedconf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jan 31, 2021
-
Refactor Config structs according to features
As it was stated in Spotifyd#349, structs like `SharedConfigValues` or `SpotifydConfig` contain fields like `mixer`, `control` and `device` which only apply if `alsa-backend` feature is enabled. Therefore, it would be nice if these fields were only documented when the feature is enabled as well as used. Closes Spotifyd#349
Configuration menu - View commit details
-
Copy full SHA for 5ddc361 - Browse repository at this point
Copy the full SHA 5ddc361View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd2c13f - Browse repository at this point
Copy the full SHA bd2c13fView commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8835bb0 - Browse repository at this point
Copy the full SHA 8835bb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a827faf - Browse repository at this point
Copy the full SHA a827fafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d55a5 - Browse repository at this point
Copy the full SHA 58d55a5View commit details -
Add suggestions to remove alsa-dependand configs
In the wiki mdbook it's not stated clearly that the config options that refer to `mixer`, `controller` and `device` can be directly commented out since they're only used when spotifyd is compiled with `alsa_backend` feature.
Configuration menu - View commit details
-
Copy full SHA for f14aea3 - Browse repository at this point
Copy the full SHA f14aea3View commit details
Commits on Feb 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b2d5d80 - Browse repository at this point
Copy the full SHA b2d5d80View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.