This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
fix: claims are not required #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
|
Claims are indeed not required. Because of a bug we ran into the same issue recently and it was fixed differently. Will leave this open to verify later this week, but should be resolved. Thanks for the PR |
nklomp
approved these changes
Sep 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the library for the most simple did auth and it seems like the
claimsfield it not required by the specification. However, it was difficult for me to find the exact answer to this as the spec did not seem to formally define this. In the data model, within this library,claimsmay be undefined so this would be inline with that.