-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bed 4752 #873
base: main
Are you sure you want to change the base?
Bed 4752 #873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Couple of nits, but, it doesn't appear we really have as much of a standard when it comes to logging warnings.
Errors are generally prefixed with one of [Error
, Failed
, Unable
], but we don't seem to have as much consensus when it comes to warn level messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request for refactor, changeset otherwise looks solid
Description
Updated specified log errors to warns in order to cut down noise.
Motivation and Context
This PR addresses: BED-4752
Why is this change required? What problem does it solve?
This change was requested to lessen confusion post releases or while investigating certain issues.
How Has This Been Tested?
No real code changes. Unit tests still pass.
Screenshots (optional):
Types of changes
Checklist: