Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed 4752 #873

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Bed 4752 #873

wants to merge 9 commits into from

Conversation

stephanieslamb
Copy link
Contributor

Description

Updated specified log errors to warns in order to cut down noise.

Motivation and Context

This PR addresses: BED-4752

Why is this change required? What problem does it solve?
This change was requested to lessen confusion post releases or while investigating certain issues.

How Has This Been Tested?

No real code changes. Unit tests still pass.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

@stephanieslamb stephanieslamb requested a review from a team as a code owner September 19, 2024 14:17
@stephanieslamb stephanieslamb self-assigned this Sep 19, 2024
@stephanieslamb stephanieslamb added the api A pull request containing changes affecting the API code. label Sep 19, 2024
Copy link
Contributor

@mvlipka mvlipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Couple of nits, but, it doesn't appear we really have as much of a standard when it comes to logging warnings.

Errors are generally prefixed with one of [Error, Failed, Unable], but we don't seem to have as much consensus when it comes to warn level messages.

packages/go/analysis/ad/esc3.go Outdated Show resolved Hide resolved
packages/go/analysis/ad/esc3.go Show resolved Hide resolved
cmd/api/src/daemons/datapipe/jobs.go Outdated Show resolved Hide resolved
packages/go/ein/azure.go Show resolved Hide resolved
Copy link
Collaborator

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request for refactor, changeset otherwise looks solid

cmd/api/src/queries/graph.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants