Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4696 feat: add preMigrationDaemons support #867

Merged
merged 2 commits into from
Sep 18, 2024
Merged

BED-4696 feat: add preMigrationDaemons support #867

merged 2 commits into from
Sep 18, 2024

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Sep 17, 2024

Description

  • Added a preMigrationDaemons property to initializer struct in order to allow daemons to start before migrations are run
  • Moved the tools api daemon to the preMigrationDaemons property to launch the API prior to migrations
  • Added a /health endpoint for infrastructure & container management

Motivation and Context

This PR addresses: BED-4696

Long running migrations on large datasets prevent the bh API /health endpoint from starting which can trip container management automation tied to the /health endpoint. This bh API /health endpoint remains unchanged and can be used in conjunction with the above to determine where in the bootstrap the process is.

How Has This Been Tested?

Force added a couple minutes sleep to the migration check
Hit GET 0.0.0.0:2112/health after launching before migration sleep finishes.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Sep 17, 2024
@mistahj67 mistahj67 self-assigned this Sep 17, 2024
@mistahj67 mistahj67 requested a review from a team as a code owner September 17, 2024 17:47
@mistahj67 mistahj67 force-pushed the BED-4696 branch 2 times, most recently from 0ae52fd to 290e971 Compare September 17, 2024 20:19
@mistahj67 mistahj67 changed the title BED-4696 feat: add preEntrypoint daemon support BED-4696 feat: add preMigrationDaemons support Sep 18, 2024
@mistahj67 mistahj67 enabled auto-merge (squash) September 18, 2024 17:48
@mistahj67 mistahj67 merged commit 64fbf92 into main Sep 18, 2024
4 checks passed
@mistahj67 mistahj67 deleted the BED-4696 branch September 18, 2024 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants