Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix healthcheck to not use env variable #864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yannis-srl
Copy link

@yannis-srl yannis-srl commented Sep 17, 2024

Description

Changing the healthcheck in the example docker compose to not use the environment variable which only specifies the exposed port.

Motivation and Context

This PR addresses: #862

This makes it possible to change the ports by setting the env variables, without bloodhound breaking.

How Has This Been Tested?

I have run it to avoid syntax errors by mistyping.

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@yannis-srl yannis-srl requested a review from a team as a code owner September 17, 2024 13:15
Copy link

github-actions bot commented Sep 17, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@yannis-srl
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@irshadaj irshadaj added the external This pull request is from an external contributor label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external This pull request is from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants