SchannelAuthenticationEnabled #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juggernot325
approved these changes
Sep 19, 2024
| @@ -2426,8 +2426,7 @@ func FetchADCSPrereqs(db graph.Database) (impact.PathAggregator, []*graph.Node, | |||
| } | |||
| } | |||
|
|
|||
| func TestADCSESC10a(t *testing.T) { //*** | |||
| t.Skip("3 Disabling test to allow engineers to continue submitting PRs and not have significant errors BED-4747") | |||
There was a problem hiding this comment.
Do you feel confident that this test will pass reliably on test runs? The skip was recently added in #822 as this test was identified as one that would fail intermittently. Based on your changes it looks like there was significant work done here, but I just wanted to double check.
| @@ -2990,8 +2989,7 @@ func TestADCSESC13(t *testing.T) { //*** | |||
| }) | |||
| } | |||
|
|
|||
| func TestADCSESC10b(t *testing.T) { //*** | |||
| t.Skip("5 Disabling test to allow engineers to continue submitting PRs and not have significant errors BED-4747") | |||
There was a problem hiding this comment.
Do you feel confident that this test will pass reliably on test runs? The skip was recently added in #822 as this test was identified as one that would fail intermittently. Based on your changes it looks like there was significant work done here, but I just wanted to double check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new CertTemplate property schannelauthenticationenabled.
Motivation and Context
Not all EKUs that enable Kerberos auth enable Schannel auth. Therefore a property for Schannel auth.
This PR addresses: BP-610
How Has This Been Tested?
By uploading this dataset: 20240902031837_BloodHound.zip
You should see a bunch of ESC6b/ESC10 edges:
The CertTemplate nodes of the composition of graphs for the above edges all have schannelauthenticationenabled = true.
Screenshots (optional):
Types of changes
Checklist: