Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mand SCS flavors in scs cluster-class template. #174

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

garloff
Copy link
Contributor

@garloff garloff commented Sep 6, 2024

  • Use SCS-2V-4-20s (note the s) as example and default for control plane nodes. We have created the small SSD flavors for exactly this use case, so let's use them. Also note that SCS-2V-4-20 is no longer guaranteed to exist on every SCS (IaaS-compatible-v3+) cloud.
  • Likewise shift to SCS-2V-4 (diskless) as default for the worker nodes. This flavor is guaranteed to exist. It will require a root volume, suggest 25GiB.
  • Clarify comments on when to use root volumes ...

What this PR does / why we need it:

The current template defaults to flavors that are no longer mandatory. So one more thing to adjust and thus worse user experience.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • Suggesting SCS-2V-4-20s for controllers (with local SSD) and SCS-2V-4 (diskless!) for workers. Those two are mandatory. Changing the default root volume to 25GiB (slightly larger) to have a bit more headroom (and to easily recognize that the volume got used instead of a local disk)
  • I have NOT tested whether the support for diskless flavors works well ... It should.
  • Obviously managed KaaS providers would adjust to their cloud, but good defaults are still considered useful, of course

TODOs:

  • squash commits
  • include documentation
  • add unit tests

* Use SCS-2V-4-20s (note the s) as example and default for control plane nodes. We have created the small SSD flavors for exactly this use case, so let's use them. Also note that SCS-2V-4-20 is no longer guaranteed to exist on every SCS (IaaS-compatible-v3+) cloud.
* Likewise shift to SCS-2V-4 (diskless) as default for the worker nodes. This flavor is guaranteed to exist. It will require a root volume, suggest 25GiB.
* Clarify comments on when to use root volumes ...

Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff self-assigned this Sep 6, 2024
@garloff garloff added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Sep 6, 2024
@garloff garloff added this to the R7 (v8.0.0) milestone Sep 6, 2024
Copy link
Member

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side. @jschoone can review with regards to the SCS context and the flavor naming.

@garloff garloff merged commit 44cd613 into main Sep 10, 2024
2 checks passed
@garloff garloff deleted the fix/use-mand-scs-flavors-in-template branch September 10, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants