Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(versions): remove 1.27 since it's EOL from today #123

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

jschoone
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@jschoone jschoone requested a review from DEiselt June 28, 2024 14:29
@DEiselt
Copy link
Contributor

DEiselt commented Jul 3, 2024

Should be fine but the base files will still be using 1.27. Do we keep it like that?
If not, we should be able to generate 1.28 and copy the result to the source dir.

@jschoone
Copy link
Contributor Author

jschoone commented Jul 4, 2024

Should be fine but the base files will still be using 1.27. Do we keep it like that? If not, we should be able to generate 1.28 and copy the result to the source dir.

Hi @DEiselt, you're right! Could you do that?

Signed-off-by: Danny Eiselt <[email protected]>
@DEiselt
Copy link
Contributor

DEiselt commented Jul 8, 2024

Should be fine but the base files will still be using 1.27. Do we keep it like that? If not, we should be able to generate 1.28 and copy the result to the source dir.

Hi @DEiselt, you're right! Could you do that?

Hi @jschoone , somehow missed your comment but it's done. Some of the changes in my commits are formatting due to the file content being "dragged" through the YAML library.

@jschoone jschoone merged commit def1048 into main Jul 9, 2024
2 checks passed
@jschoone jschoone deleted the jschoone/remove_1_27 branch July 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants