Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update kustomize to v5.4.2 version #177

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

kranurag7
Copy link
Contributor

What this PR does / why we need it:

related: SovereignCloudStack/cluster-stack-operator#219

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@kranurag7 kranurag7 marked this pull request as ready for review June 24, 2024 07:20
@cluster-stack-bot cluster-stack-bot bot added area/hack Changes made in the hack directory area/api Changes made in the api directory labels Jun 24, 2024
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can we also push forward #170?

@kranurag7
Copy link
Contributor Author

Can we also push forward #170?

I tried but I'm not able to find out the correct regex after a few iterations.

@kranurag7 kranurag7 merged commit 8f6fc65 into main Jun 24, 2024
5 checks passed
@kranurag7 kranurag7 deleted the kr/kustomize-update branch June 24, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory area/hack Changes made in the hack directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants