Add windows to test_python and fix compilation/importing
#471
Conversation
|
Github CI is being incredibly annoying, please double-check if all checks were indeed ran, and if it reaches the "Test wheel on all python versions" stage. |
ShadowJonathan
force-pushed
the
test-windows
branch
from
db7056a
to
a7f5843
Compare
|
"Test wheel on all python versions" is getting skipped. My guess is that it's because the |
|
Yeah it's because GitHub CI is/was not properly working for a couple of hours. You can hit the re-run button if you want to try it again. I've gotten it to run properly on my own fork, and I'm now encountering the import error that was encountered in the workshop, and it's a really annoying one to debug and be certain of what's happening. |
|
We seem to be running into this: actions/runner-images#9959 |
|
I found the problem; #470 (comment) Apparently, the windows builds are pointing to python39.dll, which shouldn't be the case. (Also CI will crash on the test file, since apparently you cant print an emoji...) |
|
I'll mark this as draft until I've figured this out. |
ShadowJonathan
force-pushed
the
test-windows
branch
from
83f1633
to
23810a8
Compare
ShadowJonathan
changed the title
test_pythontest_python and fix compilation/importing
|
Figured it out; you can check https://github.com/ShadowJonathan/Soar/actions/runs/9302102798/job/25602114115 for a run where it runs without requiring the ubuntu runners. Unfortunately actions/runner-images#9959 persists, and github hasnt responded to it yet, nor is it visible in https://www.githubstatus.com I'd recommend keeping an eye on that issue, and re-run the CI once it has been resolved, to see a completely green checkmark list. |
ShadowJonathan
force-pushed
the
test-windows
branch
from
d33ab8c
to
f76d738
Compare
|
Nice job! How did you fix the cp1252 issue? I've subscribed to updates on the runner issue, and I'll re-run as soon as that's resolved. Thanks for all your work! |
For Python versions 3.7 and up, there's the environment variable Do you want me to add that in comments above the env-variable setting? |
|
Ah, right! I had thought that setting was there already. Makes sense. I guess a comment is a good idea. The runner issue has been resolved, as well, so I'm re-running the jobs for this PR. |
|
Added the comment :) |
|
Grrr there's a flake on |
|
That does sound familiar. I thought I had seen a flakey test recently and recorded it but I can't find a note. I'll add something to #385. |
|
Merged! Thanks, Jonathan! |
|
Thanks! I've deleted the windows wheel on the only available release on pypi just now, and will send an email monday to all the workshop participants who reached out with their email to explain to them the issue is (most likely) fixed, and to install it via test.pypi.org, once the automatic monday build has rolled around and uploaded it :) This prevents anyone from downloading a broken wheel, but also makes Currently I don't think the situation is that speedy to require uploading more dev artifacts to pypi to fill pre-release needs, since .3 is around the corner(ish), so i think we can bear with that for now. If .3 will take a few more months, however, then that might change. |
|
I don't believe that it will take months, but I need to coordinate a bit to determine the timing. I'll let you know when I find out. |
Closes #470