Commits on May 22, 2024

1. Throw for bad param in GetParameterValue …

   Previous behavior here was to segfault! An exception is much more user-friendly.
   
   Add the SWIG machinery for catching thrown exceptions in the SML binding
   libraries, too. We wrap every SML function with a try/catch. I don't know if
   this is actually heavy or not, but at least one implementation out there thought
   it was and went an alternative route where each method has to be explicitly
   marked to catch exceptions:
   https://github.com/KiCad/kicad-source-mirror/blob/47e4ebb32a1366d60649879381eac819f7c7131d/common/swig/ki_exception.i#L41
   
   Add tests for TCL, Python and Java that demonstrate the exceptions being
   translated for each host language. We don't have C# tests yet T_T.
   
   Notice we did have to add the `atexit` handler back to prevent a segfault when
   the exception is not caught correctly; I don't know exactly why. Filed #464.
   
   Fixes #451.

   

   garfieldnate committed May 22, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 4d7a6e2
   • Browse repository at this point

   Copy the full SHA

   4d7a6e2 View commit details

   Browse the repository at this point in the history