SMem fixes #374
Merged
SMem fixes #374
+39
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harden the logic for exporting smem to prevent segfaults. Previously we had a segfault with just `smem -x file.soar` because the smem DB is not connected. Adding an LTI option, however, would connect to the DB first. Change it so that export (as with backup) requires connecting to the DB first, and gracefully returns false if not connected.
Previously a simple smem --init smem --clear at the beginning of a source file would fail and prevent the rest of the file from sourcing. Connect to the DB in the init CLI command so that any following actions can access the DB. I believe this is the intuitive behavior, and I don't see anything in the manual that would indicate that this incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 fixes related to connecting the smem DB:
smem -x foo.logto replicate).smem --init. This allows users to putsmem --initandsmem --clearfirst thing in their project sources without any errors.Fixes #370.