Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Windows version testing is not included in test_python #470

Closed
ShadowJonathan opened this issue May 29, 2024 · 1 comment · Fixed by #471
Closed

[Python] Windows version testing is not included in test_python #470

ShadowJonathan opened this issue May 29, 2024 · 1 comment · Fixed by #471

Comments

@ShadowJonathan
Copy link
Contributor

Apparently I forgot to include this in #461

We've had reports of people being unable to import soar_sml during the workshop, and while looking for possible issue sources, I spotted this massive oversight 🤦

@ShadowJonathan
Copy link
Contributor Author

ShadowJonathan commented May 30, 2024

Alright, even though actions/runner-images#9959 is as helpful to this issue as the evergreen was to the suez canal, I found the problem that comes up when adding testing;

https://github.com/ShadowJonathan/Soar/actions/runs/9291866988/job/25571809836 shows an odd error;

ImportError: Module use of python39.dll conflicts with this version of Python.

While python versions >=3.8 show an unhelpful error message ("The specified module could not be found."), this is giving me a clue that windows wheels are being incorrectly built against python 3.9's DLLs, which shouldn't be the case.

I think I encountered this issue in another form/way in #448, where I had to wrangle windows into properly seeing the right dll/library to build against, but not to link against.


There's another issue which is going to make CI fail, which is highlighted in this run

Traceback (most recent call last):
  File "D:\a\Soar\Soar\Core\ClientSMLSWIG\Python\TestPythonSML.py", line 91, in <module>
    print('\u2705 Kernel creation succeeded')
  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u2705' in position 0: character maps to <undefined>

Here it is correctly running the test file, but it chokes on that line, due to not being able to print an emoji... :/

@ShadowJonathan ShadowJonathan changed the title Windows version testing is not included in test_python [Python] Windows version testing is not included in test_python May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant