Fix remaining unused variable warnings

and enable constructor argument reordered warnings, as they are also easy to
fix and quite numerous.

Continues work on #347.

Core/ClientSMLSWIG/Tcl/Tcl_sml_ClientInterface.i

@@ -68,7 +68,6 @@
 	static int ThreadEventProc(Tcl_Event *evPtr, int mask)
 	{
 		ThreadEvent *threadEventPtr = (ThreadEvent *)evPtr;
-		ThreadEventResult *resultPtr = threadEventPtr->resultPtr;
 		Tcl_Interp *interp = dispinterp;
 		int code;
 		char const* result;
@@ -77,8 +76,6 @@
 
 		// Check which thread we're on.
 		// I hope this is the thread I asked to be part of.
-		Tcl_ThreadId currentThread = Tcl_GetCurrentThread() ;
-
 		if (interp == NULL) {
 			code = TCL_ERROR;
 			result = "no target interp!";
@@ -110,7 +107,6 @@
 	int tcl_thread_send(Tcl_Interp* interp, Tcl_ThreadId id, Tcl_Obj* script)
 	{
 		ThreadEvent *threadEventPtr;
-		ThreadEventResult *resultPtr;
 		Tcl_ThreadId threadId = (Tcl_ThreadId) id;
 
 		// Cache the interpreter so we can find it again later
@@ -122,7 +118,7 @@
 
 		threadEventPtr = (ThreadEvent *) ckalloc(sizeof(ThreadEvent));
 		threadEventPtr->script = script;
-		resultPtr = threadEventPtr->resultPtr = NULL;
+		threadEventPtr->resultPtr = NULL;
 
 		/*
 		* Queue the event and poke the other thread's notifier.

SConstruct

@@ -232,7 +232,7 @@ else:
     # cflags.extend(['-Werror'])
 
     # We're starting with something simple. We'll add more as we go.
-    cflags.append('-Wunused-variable')
+    cflags.extend(['-Wunused-variable', '-Wreorder-ctor'])
 
     # warning doesn't exist in Apple's clang
     if sys.platform != 'darwin':

SoarCLI/soar_cli.h

@@ -103,7 +103,7 @@ class InputThread : public soar_thread::Thread
         }
         bool readcmd(std::string& result)
         {
-            int nestlvl, i, n;
+            int nestlvl, n;
             std::string line;
             std::stringstream cmd;
 

UnitTests/SoarUnitTests/FullTests.cpp

@@ -449,6 +449,7 @@ void FullTests_Parent::testRHSHandler()
     no_agent_assertTrue(cppRhsHandlerReceived);
 
     no_agent_assertTrue(m_pKernel->RemoveRhsFunction(callback_rhs1));
+    no_agent_assertTrue(m_pKernel->RemoveRhsFunction(callback_rhs_cpp));
 
     // Re-add it without the bool that is getting popped off the stack
     no_agent_assertTrue(m_pKernel->AddRhsFunction("test-rhs", Handlers::MyRhsFunctionHandler, 0));

UnitTests/TestExternalLibraryLib.cpp

@@ -21,7 +21,7 @@ extern "C"
     // Soar calls this when the library is loaded
     RHS_EXPORT const char *sml_InitLibrary(Kernel *pKernel, int argc, char **argv)
     {
-        int callbackId = pKernel->AddRhsFunction("test", [](smlRhsEventId id, Agent *pAgent, char const *pFunctionName, char const *pArgument)
+        pKernel->AddRhsFunction("test", [](smlRhsEventId id, Agent *pAgent, char const *pFunctionName, char const *pArgument)
                                                  { return "myLibTest"; });
         return "";
     }