Skip to content

Commit

Permalink
Remove bad -rpath argument from Tcl link command
Browse files Browse the repository at this point in the history
Without a path argument, the first object file is added to the rpath and not
linked into the SO, leading to libtclsoarlib.so only containing symbols from
Tcl/src/main.cpp, and none from Tcl/src/TclSoarLib.cpp. I'm unsure of why this
setting was originally added and whether there used to be a real path argument.
  • Loading branch information
garfieldnate committed Aug 17, 2023
1 parent adec436 commit 39d3d66
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions Tcl/SConscript
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ if sys.platform == 'darwin':

elif sys.platform.startswith('linux'):
clone.Append(LIBS = ['Soar'])
# Currently requires Tcl 8.6 b/c it supports multiple threads without manual compilation. The following line
# hard-codes the path of the current Tcl 8.6 path on this system into the executable (it's used as the first,
# but not only, search path for the Tcl library)
# TODO: is this still needed?
clone.Append(LINKFLAGS = ['-Wl,-rpath'])
elif sys.platform == 'win32':
# Windows DLLs need to get linked to dependencies, whereas Linux and Mac shared objects do not
# (not sure if this is really needed for TclSoarLib)
Expand Down

0 comments on commit 39d3d66

Please sign in to comment.