Skip to content

Commit

Permalink
Fix disappearing + in debugger in dark mode
Browse files Browse the repository at this point in the history
Simply remove the background from the sidebar displayed behind the + buttons.
This was being explicitly set to white, while the + buttons change to white
in dark mode, so they were invisible. I tried using
`Display.isSystemDarkTheme()` to choose a different background, as well as
adding a border to it, but the minimal display really looks best. We allow
the canvas background to adjust to the color of the window, as the +'s do,
always giving good contrast and no visual noise.

Partial fix for #352.
  • Loading branch information
garfieldnate committed Jul 22, 2023
1 parent a50da75 commit 083aa44
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,7 @@
import org.eclipse.swt.graphics.Rectangle;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Canvas;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Event;
import org.eclipse.swt.widgets.Listener;
import org.eclipse.swt.widgets.Text;
import org.eclipse.swt.widgets.*;

import edu.umich.soar.debugger.modules.AbstractView;

Expand Down Expand Up @@ -773,8 +769,6 @@ public FoldingText(Composite parent)
m_Text.setLayoutData(data2);

m_IconBar.addPaintListener(this::paintIcons);
m_IconBar.setBackground(m_IconBar.getDisplay().getSystemColor(
SWT.COLOR_WHITE));

m_IconBar.addMouseListener(new MouseAdapter()
{
Expand Down

0 comments on commit 083aa44

Please sign in to comment.