Bump androidx.compose:compose-bom from 2024.08.00 to 2024.09.01 #2089

dependabot · 2024-09-11T10:28:19Z

Bumps androidx.compose:compose-bom from 2024.08.00 to 2024.09.01.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps androidx.compose:compose-bom from 2024.08.00 to 2024.09.01. --- updated-dependencies: - dependency-name: androidx.compose:compose-bom dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

github-actions · 2024-09-16T16:12:00Z

	Warnings
⚠️	One or more component files were updated, but the tests weren't updated. If your change is not covered by existing tests please add snapshot tests.
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against d845075

marianeum · 2024-09-16T16:18:28Z

app/src/main/java/net/skyscanner/backpack/demo/compose/IconsStory.kt

@@ -119,7 +119,7 @@ fun IconsStory(modifier: Modifier = Modifier) {
                        contentAlignment = Alignment.Center,
                        modifier = Modifier
                            .border(Dp.Hairline, BpkTheme.colors.line)
-                            .clickable {
+                            .clickableWithRipple {


renamed this function and made it public, so we don't need to maintain two versions (one in the app and one in backpack)

marianeum · 2024-09-16T16:19:49Z

...k-compose/src/main/kotlin/net/skyscanner/backpack/compose/bottomsheet/BpkBottomSheetState.kt

@@ -51,18 +51,6 @@ class BpkBottomSheetState internal constructor(
    internal val delegate: SheetState,
 ) {

-    constructor(


we only ever use this with the remember function. there was a breaking change with a new density param, but as we're only using it with the remember function anyways might as well remove it instead

marianeum · 2024-09-16T16:19:54Z

...pose/src/main/kotlin/net/skyscanner/backpack/compose/bottomsheet/BpkModalBottomSheetState.kt

@@ -53,18 +53,6 @@ class BpkModalBottomSheetState internal constructor(
    internal val delegate: SheetState,
 ) {

-    constructor(


marianeum · 2024-09-16T16:20:52Z

...ack-compose/src/main/kotlin/net/skyscanner/backpack/compose/button/internal/BpkButtonImpl.kt

@@ -74,7 +75,12 @@ internal fun BpkButtonImpl(
 ) {
    val clickable = enabled && !loading

-    CompositionLocalProvider(LocalRippleTheme provides ButtonRippleTheme(type.rippleColor())) {
+    CompositionLocalProvider(
+        LocalRippleConfiguration provides RippleConfiguration(


ripple theme is gone - there's now RippleConfiguration

marianeum · 2024-09-16T16:21:11Z

backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/checkbox/BpkCheckbox.kt

@@ -153,7 +154,7 @@ private fun BpkCheckboxImpl(
 ) {
    // our design system isn't designed with the minimum touch target in mind at the moment.
    // Disable the enforcement to avoid the extra padding
-    CompositionLocalProvider(LocalMinimumTouchTargetEnforcement provides false) {
+    CompositionLocalProvider(LocalMinimumInteractiveComponentSize provides Dp.Unspecified) {


this has also been changed

marianeum · 2024-09-16T16:21:30Z

backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/chip/internal/BpkChipImpl.kt

@@ -85,7 +85,7 @@ internal fun BpkChipImpl(
                    selected = selected,
                    enabled = enabled,
                    interactionSource = interactionSource,
-                    indication = rememberRipple(),
+                    indication = bpkRipple(),


added a new helper function for using the ripple directly

marianeum · 2024-09-16T16:22:10Z

...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt

-            animationSpec = interactiveBackgroundAnimationSpec,
-            label = "background scale",
-        )
+    override fun hashCode(): Int = -1


the example had that?! i am not sure when this is actually used and has an impact. but it was working as expected 🤷‍♀️

marianeum · 2024-09-16T16:22:29Z

...main/kotlin/net/skyscanner/backpack/compose/graphicpromotion/internal/BpkGraphicPromoImpl.kt

+    override fun equals(other: Any?) = other === this
+}
+
+private class InteractiveBackgroundIndicationNode(private val interactionSource: InteractionSource) : Modifier.Node(), DrawModifierNode {


migrated these to the new api

marianeum · 2024-09-16T16:23:50Z

backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/utils/Modifier.kt

-// It will be added in Compose 1.7, so we'll migrate it after that
-@Suppress("ModifierComposed")
-internal fun Modifier.clickable(
+@Suppress("ModifierComposable")


the main compose docs now mention it's better to use a composable function than the composed API. it's not really feasible to move to the node api for this as the whole clickable node is internal

dependabot · 2024-09-19T10:31:56Z

A newer version of androidx.compose:compose-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

alejandrorosas

looks good after the changes on the spinner and progressbar 😄
Q: don't we have screenshot tests for progressbar or is that they are pixel perfect to the previous version?

marianeum · 2024-09-19T10:38:45Z

Yeah they're exactly the same. The main changes in the screenshots seem to be some shadow behaviour changes (and the progress spinner but that one's fine), so anything without shadows didn't change.

dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 11, 2024

dependabot bot mentioned this pull request Sep 11, 2024

Bump androidx.compose:compose-bom from 2024.08.00 to 2024.09.00 #2083

Closed

Migrate to new APIs

a2e8e3f

marianeum reviewed Sep 16, 2024

View reviewed changes

github-actions bot and others added 2 commits September 16, 2024 16:26

Updated snapshots

55b219c

Fix lint

dd9b813

alejandrorosas approved these changes Sep 17, 2024

View reviewed changes

marianeum added the DON'T MERGE label Sep 17, 2024

marianeum and others added 5 commits September 17, 2024 11:59

Update slider to match our design system

acf8d1e

Updated snapshots

eb71255

Update progress bar to match our design system

dd3ee5b

Updated snapshots

b3c51a6

Trigger CI

d845075

marianeum removed the DON'T MERGE label Sep 17, 2024

alejandrorosas approved these changes Sep 19, 2024

View reviewed changes

marianeum merged commit 0e3c16b into main Sep 19, 2024
7 checks passed

marianeum deleted the dependabot/gradle/androidx.compose-compose-bom-2024.09.01 branch September 19, 2024 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump androidx.compose:compose-bom from 2024.08.00 to 2024.09.01 #2089

Bump androidx.compose:compose-bom from 2024.08.00 to 2024.09.01 #2089

dependabot bot commented on behalf of github Sep 11, 2024

github-actions bot commented Sep 16, 2024 •

edited

Loading

marianeum Sep 16, 2024

marianeum Sep 16, 2024

marianeum Sep 16, 2024

marianeum Sep 16, 2024

marianeum Sep 16, 2024

marianeum Sep 16, 2024

marianeum Sep 16, 2024

marianeum Sep 16, 2024

marianeum Sep 16, 2024

dependabot bot commented on behalf of github Sep 19, 2024

alejandrorosas left a comment

marianeum commented Sep 19, 2024 •

edited

Loading

Bump androidx.compose:compose-bom from 2024.08.00 to 2024.09.01 #2089

Bump androidx.compose:compose-bom from 2024.08.00 to 2024.09.01 #2089

Conversation

dependabot bot commented on behalf of github Sep 11, 2024

github-actions bot commented Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Sep 19, 2024

alejandrorosas left a comment

Choose a reason for hiding this comment

marianeum commented Sep 19, 2024 • edited Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading

marianeum commented Sep 19, 2024 •

edited

Loading