Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump destinations from 1.10.2 to 1.11.6 #2087

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024

Bumps destinations from 1.10.2 to 1.11.6.
Updates io.github.raamcosta.compose-destinations:core from 1.10.2 to 1.11.6

Release notes

Sourced from io.github.raamcosta.compose-destinations:core's releases.

1.11.5-beta

Changes

  • Dependency updates
  • Small issue fixes

Full Changelog: raamcosta/compose-destinations@1.11.4-alpha...1.11.5-beta

1.11.4-alpha

  • Fixes issue with not importing AnimatedVisibilityScope with new shared transition elements ways of providing it.

Full Changelog: raamcosta/compose-destinations@1.11.3-alpha...1.11.4-alpha

1.11.3-alpha - breaking changes and shared element transitions

Breaking Changes 😱

  • Most of our NavController extension functions were removed. Instead, if you want to use the type safe Compose Destinations friendly APIs, you'll need to use DestinationsNavigator. There are two new APIs to get this navigator from NavController: (you can also just receive DestinationsNavigator on your annotated Composables)

    • If you are inside a Composable, use navController.rememberDestinationsNavigator()
    • If not, use navController.toDestinationsNavigator()

Keep in mind you can still use NavController directly by adding .route. For example: navController.navigate(Destination(args).route).

We were forced to do this since new navigation versions introduced a new member function of NavController class that would shadow our extension functions (i.e, users of the lib would start calling it silently instead of our extension functions - the result would be a runtime crash). By removing the APIs on our side, it forces users of Compose Destinations to go handle this change and avoid runtime issues that way.

  • Parameter onlyIfResumed removed from navigate APIs. (including navigating back with result). Users should replace it with the new APIs dropUnlessResumed:
onClick = dropUnlessResumed {
    navigator.navigate(SomeDestination)
}
// BEFORE
onClick = {
navigator.navigate(SomeDestination, onlyIfResumed = true)
}

Here it was just a timing thing. Given that we were forced into other breaking changes, might as well do this too. It also made it easier to provide functions to get DestinationsNavigator (see above) since it no longer depends on the NavBackStackEntry.

Improvements

  • Changes to help send SharedTransitionScope and AnimatedVisibilityScope.

Here is the recommended way to implement shared transition elements with the library:

</tr></table> 

... (truncated)

Commits
  • 52399eb Fixed issue with sample bottom bar
  • d03907c Updates libraries to the latest milestone
  • 38fded8 Some issue fixes cherry picked from v2
  • 7c8f45f dependencies update
  • 84f7558 Fixes issue with not importing AnimatedVisibilityScope
  • fbf36a2 Fix sample app VM issue
  • 28376e0 fix sample builds
  • b3e7064 Fix shadowed extension functions of NavController pt2
  • 6a595a1 Fix shadowed extension functions of NavController pt1
  • 75da4e0 Improve usability with SharedTransitionScope as a receiver of composable dest...
  • Additional commits viewable in compare view

Updates io.github.raamcosta.compose-destinations:ksp from 1.10.2 to 1.11.6

Release notes

Sourced from io.github.raamcosta.compose-destinations:ksp's releases.

1.11.5-beta

Changes

  • Dependency updates
  • Small issue fixes

Full Changelog: raamcosta/compose-destinations@1.11.4-alpha...1.11.5-beta

1.11.4-alpha

  • Fixes issue with not importing AnimatedVisibilityScope with new shared transition elements ways of providing it.

Full Changelog: raamcosta/compose-destinations@1.11.3-alpha...1.11.4-alpha

1.11.3-alpha - breaking changes and shared element transitions

Breaking Changes 😱

  • Most of our NavController extension functions were removed. Instead, if you want to use the type safe Compose Destinations friendly APIs, you'll need to use DestinationsNavigator. There are two new APIs to get this navigator from NavController: (you can also just receive DestinationsNavigator on your annotated Composables)

    • If you are inside a Composable, use navController.rememberDestinationsNavigator()
    • If not, use navController.toDestinationsNavigator()

Keep in mind you can still use NavController directly by adding .route. For example: navController.navigate(Destination(args).route).

We were forced to do this since new navigation versions introduced a new member function of NavController class that would shadow our extension functions (i.e, users of the lib would start calling it silently instead of our extension functions - the result would be a runtime crash). By removing the APIs on our side, it forces users of Compose Destinations to go handle this change and avoid runtime issues that way.

  • Parameter onlyIfResumed removed from navigate APIs. (including navigating back with result). Users should replace it with the new APIs dropUnlessResumed:
onClick = dropUnlessResumed {
    navigator.navigate(SomeDestination)
}
// BEFORE
onClick = {
navigator.navigate(SomeDestination, onlyIfResumed = true)
}

Here it was just a timing thing. Given that we were forced into other breaking changes, might as well do this too. It also made it easier to provide functions to get DestinationsNavigator (see above) since it no longer depends on the NavBackStackEntry.

Improvements

  • Changes to help send SharedTransitionScope and AnimatedVisibilityScope.

Here is the recommended way to implement shared transition elements with the library:

</tr></table> 

... (truncated)

Commits
  • 52399eb Fixed issue with sample bottom bar
  • d03907c Updates libraries to the latest milestone
  • 38fded8 Some issue fixes cherry picked from v2
  • 7c8f45f dependencies update
  • 84f7558 Fixes issue with not importing AnimatedVisibilityScope
  • fbf36a2 Fix sample app VM issue
  • 28376e0 fix sample builds
  • b3e7064 Fix shadowed extension functions of NavController pt2
  • 6a595a1 Fix shadowed extension functions of NavController pt1
  • 75da4e0 Improve usability with SharedTransitionScope as a receiver of composable dest...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 9, 2024
@dependabot dependabot bot force-pushed the dependabot/gradle/destinations-1.11.6 branch 2 times, most recently from 09b5550 to a791ddd Compare September 16, 2024 10:39
@marianeum
Copy link
Contributor

@dependabot rebase

Bumps `destinations` from 1.10.2 to 1.11.6.

Updates `io.github.raamcosta.compose-destinations:core` from 1.10.2 to 1.11.6
- [Release notes](https://github.com/raamcosta/compose-destinations/releases)
- [Commits](raamcosta/compose-destinations@1.10.2...1.11.6)

Updates `io.github.raamcosta.compose-destinations:ksp` from 1.10.2 to 1.11.6
- [Release notes](https://github.com/raamcosta/compose-destinations/releases)
- [Commits](raamcosta/compose-destinations@1.10.2...1.11.6)

---
updated-dependencies:
- dependency-name: io.github.raamcosta.compose-destinations:core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.github.raamcosta.compose-destinations:ksp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/destinations-1.11.6 branch from a791ddd to 6de1e92 Compare September 19, 2024 12:44
@marianeum marianeum merged commit c2b0bd3 into main Sep 19, 2024
6 checks passed
@marianeum marianeum deleted the dependabot/gradle/destinations-1.11.6 branch September 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant