DON-739 - Update Search Input Summary based on new designs #2078
+230
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrik-sky
force-pushed
the
donburi/DON-739_Search_Input_update
branch
from
cb334f8
to
7fc3f7d
Compare
bvitaliyg
reviewed
Sep 26, 2024
| @@ -86,6 +86,7 @@ internal fun BpkTextFieldImpl( | |||
| minLines: Int = 1, | |||
| maxLines: Int = 1, | |||
| interactionSource: MutableInteractionSource = remember { MutableInteractionSource() }, | |||
| isFocused: Boolean? = null, | |||
There was a problem hiding this comment.
Why do we need to add this field? Can we always use the mutable interaction source instead?
There was a problem hiding this comment.
We found it caused issues with the screen reader when changing the focus state programatically.
Before
date_selector_focus_requesters.mp4
After
date_selector_focus_property.mp4
marianeum
reviewed
Sep 27, 2024
| placeholder = inputHint, | ||
| prefix = prefix, | ||
| status = BpkFieldStatus.Default, | ||
| clearAction = clearAction, | ||
| type = BpkTextFieldType.Search, | ||
| isFocused = type is BpkSearchInputSummaryType.ReadOnly && type.isFocused, |
There was a problem hiding this comment.
small thing here: I think it'd be better to change this condition to only set a non-null value for the ReadOnly type as the default input one should use the system focused state
There was a problem hiding this comment.
Yes, that makes sense. I've updated 👍
Support clear action when read only in BpkSearchInputSummary
henrik-sky
force-pushed
the
donburi/DON-739_Search_Input_update
branch
from
7fc3f7d
to
e94a353
Compare
marianeum
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the new designs for the Date Selector, we need to make some slight changes to the Search Input Summary component.
Support there being no prefix and allowing for it to be read only.
I additionally had to make a modification deeper in
BpkTextFieldImplso that the clear button will appear even though it is read only (this is why there is theNoneprefix rather than it being optional).I added the new case to the bottom of the screen in the app, see below.
Remember to include the following changes:
README.mdIf you are curious about how we review, please read through the code review guidelines