PAN-3144: BpkPrice component support style modification (#2016)

* BpkPrice component support style modification * BpkPrice component support style modification * change BpkPrice previousPrice color * Updated snapshots * update screenshot --------- Co-authored-by: jacobhuang <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Skyscanner · Jun 20, 2024 · e457217 · e457217
1 parent 59d5dbf
commit e457217
Show file tree

Hide file tree

Showing 59 changed files with 3 additions and 3 deletions.
diff --git a/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_End.png b/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_End.png
diff --git a/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Row.png b/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Row.png
diff --git a/...t.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Start.png b/...t.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Start.png
diff --git a/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_End.png b/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_End.png
diff --git a/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Row.png b/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Row.png
diff --git a/...lt/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Start.png b/...lt/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Start.png
diff --git a/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_End.png b/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_End.png
diff --git a/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Row.png b/...ault/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Row.png
diff --git a/...lt/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Start.png b/...lt/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Start.png
diff --git a/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_End.png b/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_End.png
diff --git a/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Row.png b/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Row.png
diff --git a/...ckpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Start.png b/...ckpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Start.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_End.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_End.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Row.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Row.png
diff --git a/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Start.png b/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Start.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_End.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_End.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Row.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Row.png
diff --git a/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Start.png b/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Start.png
diff --git a/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_End.png b/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_End.png
diff --git a/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Row.png b/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Row.png
diff --git a/...t.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Start.png b/...t.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Start.png
diff --git a/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_End.png b/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_End.png
diff --git a/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Row.png b/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Row.png
diff --git a/...dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Start.png b/...dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Start.png
diff --git a/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_End.png b/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_End.png
diff --git a/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Row.png b/...g/dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Row.png
diff --git a/...dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Start.png b/...dm/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Start.png
diff --git a/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_End.png b/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_End.png
diff --git a/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Row.png b/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Row.png
diff --git a/...ckpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Start.png b/...ckpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Start.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_End.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_End.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Row.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Row.png
diff --git a/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Start.png b/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Start.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_End.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_End.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Row.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Row.png
diff --git a/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Start.png b/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Start.png
diff --git a/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_End.png b/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_End.png
diff --git a/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Row.png b/...net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Row.png
diff --git a/...t.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Start.png b/...t.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.ExtraSmall_Start.png
diff --git a/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_End.png b/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_End.png
diff --git a/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Row.png b/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Row.png
diff --git a/...tl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Start.png b/...tl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Large_Start.png
diff --git a/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_End.png b/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_End.png
diff --git a/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Row.png b/.../rtl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Row.png
diff --git a/...tl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Start.png b/...tl/net.skyscanner.backpack.compose.price.BpkPriceTest_priceFull.Small_Start.png
diff --git a/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_End.png b/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_End.png
diff --git a/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Row.png b/...backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Row.png
diff --git a/...ckpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Start.png b/...ckpack.compose.price.BpkPriceTest_priceLineThroughTrailing.ExtraSmall_Start.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_End.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_End.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Row.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Row.png
diff --git a/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Start.png b/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Large_Start.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_End.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_End.png
diff --git a/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Row.png b/...nner.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Row.png
diff --git a/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Start.png b/...er.backpack.compose.price.BpkPriceTest_priceLineThroughTrailing.Small_Start.png
diff --git a/...ompose/src/main/kotlin/net/skyscanner/backpack/compose/price/internal/BpkPriceAlignEnd.kt b/...ompose/src/main/kotlin/net/skyscanner/backpack/compose/price/internal/BpkPriceAlignEnd.kt
@@ -58,7 +58,7 @@ internal fun BpkPriceAlignEnd(
             previousPrice?.let {
                 BpkText(
                     text = it,
-                    color = BpkTheme.colors.textSecondary,
+                    color = BpkTheme.colors.textError,
                     style = size.secondaryTextStyle(),
                     textDecoration = TextDecoration.LineThrough,
                 )

diff --git a/...pose/src/main/kotlin/net/skyscanner/backpack/compose/price/internal/BpkPriceAlignStart.kt b/...pose/src/main/kotlin/net/skyscanner/backpack/compose/price/internal/BpkPriceAlignStart.kt
@@ -45,7 +45,7 @@ internal fun BpkPriceAlignStart(
             previousPrice?.let {
                 BpkText(
                     text = it,
-                    color = BpkTheme.colors.textSecondary,
+                    color = BpkTheme.colors.textError,
                     style = size.secondaryTextStyle(),
                     textDecoration = TextDecoration.LineThrough,
                 )

diff --git a/...ack-compose/src/main/kotlin/net/skyscanner/backpack/compose/price/internal/BpkPriceRow.kt b/...ack-compose/src/main/kotlin/net/skyscanner/backpack/compose/price/internal/BpkPriceRow.kt
@@ -45,7 +45,7 @@ internal fun BpkPriceRow(
             BpkText(
                 modifier = Modifier.alignByBaseline(),
                 text = it,
-                color = BpkTheme.colors.textSecondary,
+                color = BpkTheme.colors.textError,
                 style = size.secondaryTextStyle(),
                 textDecoration = TextDecoration.LineThrough,
             )

diff --git a/docs/compose/Price/screenshots/default.png b/docs/compose/Price/screenshots/default.png
diff --git a/docs/compose/Price/screenshots/default_dm.png b/docs/compose/Price/screenshots/default_dm.png