Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slayer rework (Slayer hud, spawn alerts, slain time) #989

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

7azeemm
Copy link

@7azeemm 7azeemm commented Sep 4, 2024

my first time making a pull request :)

@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Sep 4, 2024
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Sep 4, 2024
@AzureAaron AzureAaron added this to the 1.23.0 milestone Sep 4, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Sep 4, 2024
@7azeemm 7azeemm changed the title Boss and MiniBoss slayer alert Boss and MiniBoss slayer alert (Edit: added mute Enderman sounds feature) Sep 4, 2024
@7azeemm
Copy link
Author

7azeemm commented Sep 4, 2024

i just added mute enderman sounds feature

@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Sep 5, 2024
@7azeemm
Copy link
Author

7azeemm commented Sep 5, 2024

okay sure, i'm also trying to make slayer HUD and slain time. once i finish i will organize all of it

@BigloBot
Copy link
Contributor

BigloBot commented Sep 5, 2024

okay sure, i'm also trying to make slayer HUD and slain time. once i finish i will organize all of it

I already have a PR up for slayer health bossbar. Dont want to colllide there :>

@7azeemm
Copy link
Author

7azeemm commented Sep 5, 2024

uh, i'm working on slayer general info like lvl, xp to next lvl, bosses to kill, kill time. this wont hurt your PR for sure :)

- Added Boss slain time
- Tracking all slayer info
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Sep 9, 2024
@7azeemm
Copy link
Author

7azeemm commented Sep 9, 2024

Overall changes:

  • Added Slayer HUD
  • Added Boss slain time
  • Added Boss and MiniBoss spawn alert
  • Added Mute Enderman sounds
  • Tracking all slayer info
  • Works with existing slayer stuff

@7azeemm 7azeemm changed the title Boss and MiniBoss slayer alert (Edit: added mute Enderman sounds feature) Slayer rework (Slayer hud, spawn alerts, slain time) Sep 9, 2024
@kevinthegreat1
Copy link
Collaborator

Sorry, but there's a lot going on with the hud and slayers at the time. I'd suggest leaving this until #816 is merged and then I'll look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature reviews needed This PR needs reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants