Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slayer icons #970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IllagerCaptain
Copy link
Contributor

This PR changes all slayer icons in the profile viewer to the JAPPA textures, with exception of Revenant Horror, which uses Hypixel's custom texture. For vampire see #969.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Aug 29, 2024
@BigloBot
Copy link
Contributor

I don't think it should be angry wolf. I'm also not entirely convinced using the playerhead instead of the zombie texture 🤔

@IllagerCaptain
Copy link
Contributor Author

I don't think it should be angry wolf. I'm also not entirely convinced using the playerhead instead of the zombie texture 🤔

Angry wolf is used in-game.

@AzureAaron AzureAaron added this to the 1.22.1 milestone Aug 29, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 30, 2024
@AzureAaron AzureAaron modified the milestones: 1.22.1, 1.23.0 Aug 30, 2024
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Sep 3, 2024
@BigloBot
Copy link
Contributor

BigloBot commented Sep 8, 2024

It spends most as its time as a happy wolf in game.
It's also known as zombie slayer so I think it should go with the zombie head
(I also think the rev head without the 3d 'hat' elements makes it look rather silly)
2024-09-08_01 44 45

@IllagerCaptain
Copy link
Contributor Author

IllagerCaptain commented Sep 11, 2024

It spends most as its time as a happy wolf in game. It's also known as zombie slayer so I think it should go with the zombie head (I also think the rev head without the 3d 'hat' elements makes it look rather silly) 2024-09-08_01 44 45

It does have the hat layer, it's just overlayed on top with the same scale as the main head, similar to skins in the vanilla tablist. I'm pretty sure the angry wolf texture not being used is a bug with newer versions on Hypixel, from all the sources I looked at it uses angry wolf in 1.8, which is likely the intended behavior.

@BigloBot
Copy link
Contributor

It spends most as its time as a happy wolf in game. It's also known as zombie slayer so I think it should go with the zombie head (I also think the rev head without the 3d 'hat' elements makes it look rather silly) 2024-09-08_01 44 45

It does have the hat layer, it's just overlayed on top with the same scale as the main head, similar to skins in the vanilla tablist. I'm pretty sure the angry wolf texture not being used is a bug with newer versions on Hypixel, from all the sources I looked at it uses angry wolf in 1.8, which is likely the intended behavior.

I think it should stick with what we see rather than guessing intended behaviour. Angry wolf also looks very out of place on the menu.

@IllagerCaptain
Copy link
Contributor Author

It spends most as its time as a happy wolf in game. It's also known as zombie slayer so I think it should go with the zombie head (I also think the rev head without the 3d 'hat' elements makes it look rather silly) 2024-09-08_01 44 45

It does have the hat layer, it's just overlayed on top with the same scale as the main head, similar to skins in the vanilla tablist. I'm pretty sure the angry wolf texture not being used is a bug with newer versions on Hypixel, from all the sources I looked at it uses angry wolf in 1.8, which is likely the intended behavior.

I think it should stick with what we see rather than guessing intended behaviour. Angry wolf also looks very out of place on the menu.

Should it also be changed to use the ashen wolf skin, which is implemented on alpha?

@BigloBot
Copy link
Contributor

It spends most as its time as a happy wolf in game. It's also known as zombie slayer so I think it should go with the zombie head (I also think the rev head without the 3d 'hat' elements makes it look rather silly) 2024-09-08_01 44 45

It does have the hat layer, it's just overlayed on top with the same scale as the main head, similar to skins in the vanilla tablist. I'm pretty sure the angry wolf texture not being used is a bug with newer versions on Hypixel, from all the sources I looked at it uses angry wolf in 1.8, which is likely the intended behavior.

I think it should stick with what we see rather than guessing intended behaviour. Angry wolf also looks very out of place on the menu.

Should it also be changed to use the ashen wolf skin, which is implemented on alpha?

If that's what they roll with for the mins too then ya, otherwise I think base wolf is fine

@IllagerCaptain
Copy link
Contributor Author

It spends most as its time as a happy wolf in game. It's also known as zombie slayer so I think it should go with the zombie head (I also think the rev head without the 3d 'hat' elements makes it look rather silly) 2024-09-08_01 44 45

It does have the hat layer, it's just overlayed on top with the same scale as the main head, similar to skins in the vanilla tablist. I'm pretty sure the angry wolf texture not being used is a bug with newer versions on Hypixel, from all the sources I looked at it uses angry wolf in 1.8, which is likely the intended behavior.

I think it should stick with what we see rather than guessing intended behaviour. Angry wolf also looks very out of place on the menu.

Should it also be changed to use the ashen wolf skin, which is implemented on alpha?

If that's what they roll with for the mins too then ya, otherwise I think base wolf is fine

They did it for every wolf.

@BigloBot
Copy link
Contributor

It spends most as its time as a happy wolf in game. It's also known as zombie slayer so I think it should go with the zombie head (I also think the rev head without the 3d 'hat' elements makes it look rather silly) 2024-09-08_01 44 45

It does have the hat layer, it's just overlayed on top with the same scale as the main head, similar to skins in the vanilla tablist. I'm pretty sure the angry wolf texture not being used is a bug with newer versions on Hypixel, from all the sources I looked at it uses angry wolf in 1.8, which is likely the intended behavior.

I think it should stick with what we see rather than guessing intended behaviour. Angry wolf also looks very out of place on the menu.

Should it also be changed to use the ashen wolf skin, which is implemented on alpha?

If that's what they roll with for the mins too then ya, otherwise I think base wolf is fine

They did it for every wolf.

then i think thats sweet, as long as it doesnt look very dumb as a 2d head lol

@IllagerCaptain
Copy link
Contributor Author

It spends most as its time as a happy wolf in game. It's also known as zombie slayer so I think it should go with the zombie head (I also think the rev head without the 3d 'hat' elements makes it look rather silly) 2024-09-08_01 44 45

It does have the hat layer, it's just overlayed on top with the same scale as the main head, similar to skins in the vanilla tablist. I'm pretty sure the angry wolf texture not being used is a bug with newer versions on Hypixel, from all the sources I looked at it uses angry wolf in 1.8, which is likely the intended behavior.

I think it should stick with what we see rather than guessing intended behaviour. Angry wolf also looks very out of place on the menu.

Should it also be changed to use the ashen wolf skin, which is implemented on alpha?

If that's what they roll with for the mins too then ya, otherwise I think base wolf is fine

They did it for every wolf.

then i think thats sweet, as long as it doesnt look very dumb as a 2d head lol

They reverted it on this alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants