Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Title Screen #925

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

aiden-powers
Copy link
Contributor

@aiden-powers aiden-powers commented Aug 14, 2024

Discord Discussion

After two days of feedback, the discord landed on the title screen design "m+s1"
image

Also includes a new panorama texture, inside the skyblock main area
image

The pack is enabled by default, as it would be a branding piece of the modpack.
image

Notes: This only affects the title screen.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Aug 14, 2024
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Aug 15, 2024
@kevinthegreat1
Copy link
Collaborator

The splashes part seem incomplete right now? I wonder if there's a way to load splashes from Tips directly.

@aiden-powers
Copy link
Contributor Author

The splashes part seem incomplete right now? I wonder if there's a way to load splashes from Tips directly.

Tips are very long, too small to read. The splashes file is shortened versions of the tips.

Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cleaned up a little bit. Made the pack enabled by default not always enabled and removed some useless merge commits.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 23, 2024
@AzureAaron
Copy link
Collaborator

AzureAaron commented Aug 28, 2024

shouldn't this go to the modpack repo? It would be very out of place to have in the mod itself especially as its enabled by default and adds a few more megabytes to the JAR file

@AzureAaron AzureAaron added question Further information is requested and removed merge me please Pull requests that are ready to merge labels Aug 30, 2024
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts This PR has merge conflicts that need solving. new feature This issue or PR is a new feature question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants