Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to display numbers for commissions #876

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added option to display numbers for commissions #876

wants to merge 2 commits into from

Conversation

MisterCheezeCake
Copy link

This adds the option to display numbers for coms in the Dwarven HUD instead of percentages.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 29, 2024
kevinthegreat1
kevinthegreat1 requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks pretty good, I just have some small suggestions.

src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/component/ProgressComponent.java Show resolved Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/hud/HudCommsWidget.java Outdated Show resolved Hide resolved
src/main/resources/fabric.mod.json Outdated Show resolved Hide resolved
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jul 30, 2024
@kevinthegreat1 kevinthegreat1 added the new feature This issue or PR is a new feature label Jul 30, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Jul 31, 2024
kevinthegreat1
kevinthegreat1 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks for contributing.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 31, 2024
@kevinthegreat1
Copy link
Collaborator

This unfortunately conflicts with the hud pr, we'll try to make a decision.

@kevinthegreat1 kevinthegreat1 removed the merge me please Pull requests that are ready to merge label Aug 10, 2024
@kevinthegreat1
Copy link
Collaborator

Depends on #816.

@AzureAaron AzureAaron added this to the 1.23.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat left review comments

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MisterCheezeCake @kevinthegreat1 @viciscat @LifeIsAParadox @AzureAaron