Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnSet lacks ARIA roles, breaks JAWS #616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

revin
Copy link

@revin revin commented Jun 5, 2013

The ColumnSet mixin isn't providing ARIA roles for the DOM it's creating, and this is apparently causing JAWS to skip reading the content contained therein.

I'm not terribly familiar with all the nuances of ARIA roles, but from my reading of the spec, I would've thought that all it would take is adding [role=presentation] to the .dgrid-row-table node created in createRowCells(). However, the testing team I'm working with reports that this isn't sufficient, and that JAWS isn't reading the content until we add [role=presentation] to some other nodes created by this mixin. After that's done, JAWS is apparently perfectly happy.

I have no way of testing this here on my machine at this point, so I can't verify the accuracy of the findings, but I've prepared a pull request with the changes anyway, if only to kick off a discussion.

(apologies for the proxy submission; this is coming from a project for a client who's not particularly GitHub-savvy)

@revin
Copy link
Author

revin commented Jun 11, 2013

Oops, realized I'd typo'd the attribute names; fixed it. (I originally lost my fix due to a git mistake, then just retyped it from memory like a n00b)

@kfranqueiro
Copy link
Contributor

I happen to have a VM lying around with JAWS 13 installed, so I gave this a test run in that. I'm finding that even without the patch, though, it's reading all of the grid's contents fine (using one of the grids in test/complex_column.html to test).

The fix seems harmless enough, but still, I'd ideally like to see the problem it actually fixes. Do you have any information as to what specific JAWS version is being used, which browser the problem is observed in (I tested IE8 and Firefox), and perhaps a specific test case that shows the problem?

@revin
Copy link
Author

revin commented Jul 3, 2013

I asked, and the response I got was Jaws 14 in Chrome (I assume stable), FF (I'm guessing 21 or 22), and IE9, and that it's not reading the content in the grids in test/complex_column.html for them: "It reads only the header row for the first column set". That's as specific an answer as I could get :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants