Added Jukebox (#26736) #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Jukebox, along with music for jukebox * Fixed Jukebox meta.json copyright * Removed songs I couldn't find a license for. * Renamed files to solve check failures from spaces * Added missing attributions.yml * Fixed lack of description in Jukebox * Jukebox is now constructable. * Change Jukebox menu to FancyWindow * Moved Jukebox messages out of jukebox component * Removed Jukebox OnValueChanged. * JukeboxComp now uses AutoGenerateComponentState * Removed state code, since it's auto generated * Fixed various Jukebox code to match conventions. * Updated Standard.yml to match changed song list. * fixes * Jukebox workin * Fix * Polishing * Finalising * Revert * bad * jukey * Reviews * name * Update submodule to 218.2.0 --------- Co-authored-by: iNVERTED <[email protected]>
github-actions
bot
added
Changes: Audio
|
Test fail is legitimate. |
Added: Jukebox circuit board
VMSolidus
requested changes
Aug 26, 2024
DangerRevolution
added
Size: 2-Large
|
Fill out the PR please; add a changelog and (optionally) add a video of it working. |
DangerRevolution
requested review from
DEATHB4DEFEAT,
Pspritechologist,
Peptide90 and
OldDanceJacket
I can not get a local build to work for me, however, it works for everyone else. I wont be able to add a video of it working, or a snapshot of what it looks like in game |
VMSolidus
approved these changes
Aug 26, 2024
FoxxoTrystan
requested changes
Aug 29, 2024
FoxxoTrystan
approved these changes
Sep 2, 2024
SimpleStation14
added a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds super cool super nice Jukebox to the bar! Ran off .ogg files, can use any royalty free song.
Media
![Example Media on]
Changelog
🆑 Kacey, Nova