Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respace Species Code #3

Closed
wants to merge 4 commits into from
Closed

Respace Species Code #3

wants to merge 4 commits into from

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Mar 17, 2024

"Edited from its original purpose"

Summary

This PR was originally going to be a complete removal of any mention of DeltaV/Nyanotrasen/Simplestation from the codebase, and instead I have elected to significantly reduce the scope of this PR. Instead of blanket doing all rebrandings in a single PR, this PR simply acts to move all Species-specific code from their original locations, to a single unified location that is identical across Server, Shared, and Client. This takes the form of the newly repurposed Species folder. The directory should be set to be the following:

Content.X.Species

One folder for each playable species, eg: Human, Felinids, Harpy, etc.

Components
Systems
Cvars

This is not going to represent the final location for each of the Species specific code. But it is going to serve as a suitable location to store all currently existing species-specific systems. I will reorganize other parts of the repository in separate PRs

@VMSolidus VMSolidus marked this pull request as draft March 17, 2024 05:16
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title start of debranding Rebranding to Einstein Engines Mar 17, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 3-Medium For medium issues/PRs Priority: 1-Urgent Must be resolved immediately labels Mar 17, 2024
@VMSolidus
Copy link
Member Author

I have updated both the title, summary, and objectives of this PR to reflect a more realistic scope.

@VMSolidus VMSolidus marked this pull request as ready for review March 18, 2024 01:59
@VMSolidus VMSolidus changed the title Rebranding to Einstein Engines Migrating species code to core code Mar 18, 2024
@VMSolidus
Copy link
Member Author

image
Wew, and now I have tests plus compiler pass. This is nearly as far as I can tell, all of the species code that previously existed spread across DeltaV, Nyanotrasen, and Simplestation14, now placed inside Content.X.Species. Not all of it should stay there indefinitely, but for the sake of organization they're all now in a unified place that's easy to find.

@DEATHB4DEFEAT DEATHB4DEFEAT added the Type: Respace Moving something from an old namespace label Mar 19, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Migrating species code to core code Respace Species Code Mar 19, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Config Changes any configuration files Changes: YML Changes any yml files labels Mar 21, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the Felinids folder to Felinid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the Felinids folder to Felinid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is used by things other than Arachne, put it back

@VMSolidus
Copy link
Member Author

I'm closing this as per a notice for our new policy regarding code respacing. As stated on our discord at this link:
https://discord.com/channels/1218698320155906090/1218698321053356059/1224795186689867818

@VMSolidus VMSolidus closed this Apr 2, 2024
FoxxoTrystan pushed a commit to FoxxoTrystan/Einstein-Engines that referenced this pull request May 6, 2024
Saltern Redux, Interdyne hand-me-downs
dasprino007 pushed a commit to dasprino007/Einstein-Engines that referenced this pull request Jul 20, 2024
angelofallars pushed a commit to angelofallars/Einstein-Engines that referenced this pull request Aug 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Config Changes any configuration files Changes: YML Changes any yml files Priority: 1-Urgent Must be resolved immediately Size: 3-Medium For medium issues/PRs Type: Respace Moving something from an old namespace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants