Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Improves Medical Hud interface and functionality #253

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26027: Improves Medical Hud interface and functionality from space-wizards space-wizards/space-station-14

8d40bc36a93d3d5c6d3ece6c662ac9747f7837ae

PR opened by DoutorWhite at 2024-03-12 07:00:06 UTC


PR changed 8 files with 78 additions and 13 deletions.

The PR had the following labels:

  • Changes: Sprites
  • Status: Awaiting Changes

Original Body

About the PR

There are some changes to the Medical Hud interface: The icon has been changed and now there is one for each mob state, making it easier to recognize whether the mob is rotting, dead or crit.

Why / Balance

It's more visually pleasing and helps with discerning mob states.

Technical details

There is a decision structure for determining which icon is appropriate for the mob's state. It's the only relevant code change.

Media

Captura de tela 2024-03-13 230527

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Introduce new health status icons.
  • tweak: Enhance the Medical HUD to display the health status of players and mobs using the newly added icons.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
Copy link
Contributor

RSI Diff Bot; head commit 3a52964 merging into 3bf08c7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Misc/health_icons.rsi

State Old New Status
Fine Modified
Critical Added
Dead Added
Rotting Added

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 9, 2024 05:06
Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

So far i dont see any issues and seem to be working.

image

@DangerRevolution DangerRevolution requested a review from a team May 11, 2024 01:32
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 11, 2024
@DangerRevolution DangerRevolution added Changes: UI Changes any XAML files Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point Changes: Sprite Changes any png or json in an RSI Type: Feature Creation of or significant changes to a feature labels May 11, 2024
@VMSolidus VMSolidus merged commit 999ef0c into Simple-Station:master May 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Changes: UI Changes any XAML files Priority: 3-Medium Needs to be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants