Reading roll from navigation.attitude object #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per specs navgation.attitude contains an object containing pitch, roll and yaw. navigation.attitude.roll should not exist anymore.
Test using Mocha closeTo w/ delta
Test was failing because of change in variation value (mag north drifting). Check now using expectedRange/closeTo with delta.
|
There are unrelated commits here. |
|
Do you mean the division by zero bit? I can remove that and make it a separate one. |
|
The commits list is messy because it’s not based off master, but that does not matter, easy enough to squash and merge in Github. But I think stw = 0 case should return a pathvalue with value set to null to erase the previous value. The boat stops, so leeway does not really have a valid value any more calculated like this. Or alternatively it should be zero. Or what do you think? |
|
This thing still alive? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per specs navgation.attitude contains an object containing pitch, roll and yaw.
navigation.attitude.roll should not exist anymore.