jenkins ci to github actions #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlin-sift
reviewed
Jun 21, 2024
.github/workflows/ci.yml
Outdated
| - name: Validate composer.json and composer.lock | ||
| run: | | ||
| sudo composer self-update | ||
| - name: Cache Composer packages |
There was a problem hiding this comment.
I do not think we need cache. Based on https://github.com/actions/cache?tab=readme-ov-file#cache-limits, caches that are not accessed within the last week will be evicted. Consider the frequency of the changes in this repo, the cache will most likely be evicted. Also, the build is pretty fast. I do not see the benefit of cache.
jlin-sift
approved these changes
Jun 21, 2024
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Jenkinc CI to GH actions
Summary
Jenkinc CI to GH actions
Testing
Testing integration tests
https://github.com/SiftScience/sift-php/actions/runs/9605537571/job/26493378684
only buids
https://github.com/SiftScience/sift-php/actions/runs/9605562465
Checklist