Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning and Online-Monitor #19

Merged
merged 47 commits into from
Apr 27, 2020
Merged

Tuning and Online-Monitor #19

merged 47 commits into from
Apr 27, 2020

Conversation

YannickDieter
Copy link
Collaborator

@YannickDieter YannickDieter commented Mar 30, 2020

This PR adds:

  • noise tuning and a noise occ. scan for Mimosa26 telescope.
  • dedicated online monitor is now available with a 'generic' hit correlator (basically any DUT can now be correlated with each other).
  • python3 support

Fixes issue #7, #18.
Related to #12, #10.

@YannickDieter
Copy link
Collaborator Author

I dont know why travis status is not shown, but for Python3 travis passes. For python2 the unit tests for the online monitor fail.
This is due to the fact that the Tabs (in the online monitor) for the Hit Correlator and DUT Receiver are at different positions when using python2 or python3. At the moment they are recognized by their index (see here), which makes it impossible to test it for both python versions at the same time.

@DavidLP Do you know more about that? The .yaml config file is stored on alphabetically order for both versions. In case of python3 the Tabs will be sorted in that way. For python2 it is the other way around.

@YannickDieter
Copy link
Collaborator Author

YannickDieter commented Mar 30, 2020

In principle I am done with that MR.

One thing which needs to be discussed is, if we want to move the hit_correlator (which is now generic and can correlate DUTs from differnt input data streams) to our silab_online_monitor repo. In my opinion we should do that. What do you think? @laborleben @themperek @DavidLP

@themperek themperek requested a review from DavidLP March 30, 2020 14:43
@laborleben
Copy link
Contributor

@YannickDieter One cannot rely on the sorting of a python dictionary. Here is why: https://portingguide.readthedocs.io/en/latest/dicts.html

@laborleben
Copy link
Contributor

@DavidLP @YannickDieter Pushed a fix for the online-monitor addressing failing test: SiLab-Bonn/online_monitor#17

@laborleben
Copy link
Contributor

@YannickDieter Fixed.

@YannickDieter
Copy link
Collaborator Author

@laborleben Thanks for fixing that! I guess it is now finally ready to merge.

One more question: Why do your commits have a travis status, but my commits do not show any travis status?

@laborleben
Copy link
Contributor

@YannickDieter Can you check the boxes of issue #10?

@laborleben laborleben changed the title Enhancements Tuning and Online-Monitor Apr 22, 2020
@YannickDieter
Copy link
Collaborator Author

So far only the local thresholds (A, B, C, D) are tuned. Nevertheless I would just merge it, I will add the missing features later. Unfortunately I could never really test the tuning during testbeam..

@laborleben
Copy link
Contributor

@YannickDieter @DavidLP Should we use this opportunity to update the pyBAR_mimosa26_interpreter package name?

@laborleben
Copy link
Contributor

@YannickDieter
Copy link
Collaborator Author

YannickDieter commented Apr 23, 2020

Yes, in my opinion we should do that! Since a long time this is now on my ToDo list..

@laborleben laborleben merged commit 7b5e082 into master Apr 27, 2020
@laborleben laborleben deleted the enhancements branch April 27, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants