-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuning and Online-Monitor #19
Conversation
I dont know why travis status is not shown, but for Python3 travis passes. For python2 the unit tests for the online monitor fail. @DavidLP Do you know more about that? The .yaml config file is stored on alphabetically order for both versions. In case of python3 the Tabs will be sorted in that way. For python2 it is the other way around. |
In principle I am done with that MR. One thing which needs to be discussed is, if we want to move the hit_correlator (which is now generic and can correlate DUTs from differnt input data streams) to our silab_online_monitor repo. In my opinion we should do that. What do you think? @laborleben @themperek @DavidLP |
eda7aed
to
6fe69ad
Compare
@YannickDieter One cannot rely on the sorting of a python dictionary. Here is why: https://portingguide.readthedocs.io/en/latest/dicts.html |
@DavidLP @YannickDieter Pushed a fix for the online-monitor addressing failing test: SiLab-Bonn/online_monitor#17 |
…fix unittest for Python 3.5 and lower
@YannickDieter Fixed. |
@laborleben Thanks for fixing that! I guess it is now finally ready to merge. One more question: Why do your commits have a travis status, but my commits do not show any travis status? |
@YannickDieter Can you check the boxes of issue #10? |
So far only the local thresholds (A, B, C, D) are tuned. Nevertheless I would just merge it, I will add the missing features later. Unfortunately I could never really test the tuning during testbeam.. |
@YannickDieter @DavidLP Should we use this opportunity to update the pyBAR_mimosa26_interpreter package name? |
Github link for that: https://help.github.com/en/github/administering-a-repository/renaming-a-repository |
Yes, in my opinion we should do that! Since a long time this is now on my ToDo list.. |
This PR adds:
Fixes issue #7, #18.
Related to #12, #10.