Fix content in SVG files #4503
Merged
Fix content in SVG files #4503
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Thank you for this PR, @montalvomiguelo! LGTM and works as expected :) Great stuff 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4499
WHAT is this pull request doing?
Handles SVG files as text in MIME type detection
How to test your changes?
Serve a theme and add/update an SVG file
Before
After
cc @benjaminsehl
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist