[dnm] Prototype store execute command
#4493
Conversation
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Unused files (1)
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1889 tests passing in 857 suites. Report generated by 🧪jest coverage report action from 6eb8cd2 |
| }), | ||
| shop: Flags.string({ | ||
| description: 'The shop domain to execute the script against', | ||
| required: true, |
There was a problem hiding this comment.
What about making this flag optional and listing the available stores when it's not present?
| required: true, | ||
| env: 'SHOPIFY_FLAG_SCRIPT_FILE', | ||
| }), | ||
| shop: Flags.string({ |
There was a problem hiding this comment.
We call it store in other places
| if (!store) { | ||
| throw new Error('STORE_FQDN environment variable is not set') | ||
| } | ||
|
|
||
| if (!accessToken) { | ||
| throw new Error('ACCESS_TOKEN environment variable is not set') | ||
| } | ||
|
|
||
| if (!apiVersion) { | ||
| throw new Error('API_VERSION environment variable is not set') | ||
| } |
There was a problem hiding this comment.
I don't think we need so many checks when we are running this script and setting the variables ourselves.
|
|
||
| static flags = { | ||
| ...globalFlags, | ||
| 'script-file': Flags.string({ |
There was a problem hiding this comment.
What about calling it script to simplify?
There was a problem hiding this comment.
Not sure if this is the best place, but I'd definitely add a few examples somewhere with the most common operations.
No description provided.