Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation work for consistent-dev #4304

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Preparation work for consistent-dev #4304

merged 10 commits into from
Aug 12, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

Some utility changes to prepare for consistent-dev and break the changes in multiple PRs to redude their size.

WHAT is this pull request doing?

  • Use the handle for the assets folder name in the manifest.
  • Use the handle as the default identifier for the bundle output of extensions (when there isn't a local identifier)
  • Add the store FQDN to the renderDev config object (will be used later)
  • Normalize the store FQDN when using it in the dev session API
  • Add a new function to generate a temporary directory.
  • For some app-management-client queries, return a mock and show a warning instead of crashing.

How to test your changes?

Nothing relevant to test here, all changes will be used in a future PR

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Aug 9, 2024

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.78% (+0.08% 🔼)
8014/11011
🟡 Branches
69.26% (+0.02% 🔼)
3909/5644
🟡 Functions
71.43% (+0.01% 🔼)
2098/2937
🟡 Lines
73.11% (+0.08% 🔼)
7576/10362
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension-instance.ts
85.4%
75.24% (-2.21% 🔻)
91.3% 86.72%
🔴
... / app-management-client.ts
19.31% (-0.25% 🔻)
11.11% 19.57%
17.37% (-0.25% 🔻)
🟡
... / fs.ts
62.5% (-0.79% 🔻)
84.62%
58.97% (-1.55% 🔻)
62.5% (-0.79% 🔻)

Test suite run success

1811 tests passing in 824 suites.

Report generated by 🧪jest coverage report action from 0ff8343

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/fs.d.ts
@@ -19,6 +19,11 @@ export declare function stripUpPath(path: string, strip: number): string;
  * @param callback - The callback that receives the temporary directory.
  */
 export declare function inTemporaryDirectory<T>(callback: (tmpDir: string) => T | Promise<T>): Promise<T>;
+/**
+ * Return a temporary directory
+ * @returns - The path to the temporary directory.
+ */
+export declare function tempDirectory(): string;
 /**
  * It reads a file and returns its content as a string using the
  * utf-8 encoding.

@isaacroldan isaacroldan added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 87ef3e1 Aug 12, 2024
36 checks passed
@isaacroldan isaacroldan deleted the consistent-dev-prework branch August 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants