Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions_368 Fixing indentation and spacing in app logs cli #4303

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

saga-dasgupta
Copy link
Contributor

@saga-dasgupta saga-dasgupta commented Aug 9, 2024

Ticket

WHY are these changes introduced?

The CLI indentation and space formatting of app run logs for input and output of a function run did not tally up with the specs.

WHAT is this pull request doing?

  • Adding indentation for log file output.
  • Adding single line space between input and output
  • Removing space between "run" executed in 0.4190 and M instructions.

How to test your changes?

  1. Checkout this branch in local, dev up and pnpm install.
  2. Create a functions app in local, install it in your dev store.
  3. Run pnpm run shopify app logs --path <path to functions app in your local system> from the cli directory where you have checked out this branch.
  4. Trigger functions run from your dev store.
Screenshot 2024-08-09 at 9 58 51 AM

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.65% (-0.06% 🔻)
7922/10905
🟡 Branches
69.39% (+0.15% 🔼)
3888/5603
🟡 Functions
71.37% (-0.05% 🔻)
2082/2917
🟡 Lines
72.98% (-0.06% 🔻)
7486/10258
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / headers.ts
100% 90% 100% 100%
🔴
... / retry.ts
0% 100% 0% 0%
🟢
... / throttler.ts
79.31% 62.5% 84.62% 85.19%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / api.ts
9.52% (-58.04% 🔻)
0% (-43.48% 🔻)
0% (-75% 🔻)
10.53% (-57.08% 🔻)

Test suite run success

1809 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from 9d41340

@saga-dasgupta saga-dasgupta marked this pull request as ready for review August 9, 2024 15:13
Copy link
Contributor

github-actions bot commented Aug 9, 2024

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

@DuncanUszkay1 DuncanUszkay1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@saga-dasgupta saga-dasgupta force-pushed the function.368.formatting_cli_logs branch from 61a0400 to 9d41340 Compare August 9, 2024 15:36
@saga-dasgupta saga-dasgupta added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 43e6390 Aug 12, 2024
36 checks passed
@saga-dasgupta saga-dasgupta deleted the function.368.formatting_cli_logs branch August 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants