Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull GraphQL schema files from spin #4297

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Pull GraphQL schema files from spin #4297

merged 3 commits into from
Aug 11, 2024

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Aug 8, 2024

WHY are these changes introduced?

To aid with CLI changes to match changes being made in spin.

WHAT is this pull request doing?

When running bin/spin pnpm graphql-codegen:get-graphql-schemas, it will pull from spin instead of from the repos.

How to test your changes?

Make a change in spin and run bin/spin p graphql-codegen:get-graphql-schemas, you should see the updated change locally.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.65% (-0.06% 🔻)
7922/10905
🟡 Branches
69.39% (+0.15% 🔼)
3888/5603
🟡 Functions
71.37% (-0.05% 🔻)
2082/2917
🟡 Lines
72.98% (-0.06% 🔻)
7486/10258
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / headers.ts
100% 90% 100% 100%
🔴
... / retry.ts
0% 100% 0% 0%
🟢
... / throttler.ts
79.31% 62.5% 84.62% 85.19%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / api.ts
9.52% (-58.04% 🔻)
0% (-43.48% 🔻)
0% (-75% 🔻)
10.53% (-57.08% 🔻)

Test suite run success

1809 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from da85fc5

@shauns shauns self-requested a review August 9, 2024 11:01
@amcaplan amcaplan added this pull request to the merge queue Aug 11, 2024
Merged via the queue into main with commit 142797e Aug 11, 2024
35 checks passed
@amcaplan amcaplan deleted the pull-graphql-from-spin branch August 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants