Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cloudflared and use the new release for ARM64 #4289

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Aug 8, 2024

WHY are these changes introduced?

The latest release from cloudflared finally includes the ARM64 version, so we can use it and not require Rosetta anymore.

WHAT is this pull request doing?

  • Upgrades cloudflared
  • Uses the new release for the ARM64 platform
  • Removes an error related to Rosetta

How to test your changes?

  • p shopify app dev
  • ./packages/plugin-cloudflare/bin/cloudflared version => 2024.8.2
  • Ensure Rosetta is not used:
    • ./packages/plugin-cloudflare/bin/cloudflared tunnel --url localhost:8080
    • Open the Activity Monitor
    • Filter by cloudflared
    • Check that it shows Apple in the Kind column

Tested in Mac/Linux/Windows

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.62% (+0.1% 🔼)
7913/10897
🟡 Branches
69.39% (+0.04% 🔼)
3885/5599
🟡 Functions
71.33% (+0.03% 🔼)
2077/2912
🟡 Lines
72.95% (+0.11% 🔼)
7478/10251
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1805 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from 93bfa64

@gonzaloriestra
Copy link
Contributor Author

/snapit

Copy link
Contributor

github-actions bot commented Aug 8, 2024

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review August 8, 2024 16:20
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit f578449 Aug 8, 2024
37 checks passed
@gonzaloriestra gonzaloriestra deleted the upgrade-cloudflared branch August 8, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants