Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error when storeFromFqdn fails #4272

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Aug 6, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-app-inner-loop/issues/1805

WHAT is this pull request doing?

A small bug-fix in the ui

before
image

after
image

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/ui.d.ts
@@ -7,7 +7,7 @@ import { AlertOptions } from '../../private/node/ui/alert.js';
 import { CustomSection } from '../../private/node/ui/components/Alert.js';
 import ScalarDict from '../../private/node/ui/components/Table/ScalarDict.js';
 import { TableColumn, TableProps } from '../../private/node/ui/components/Table/Table.js';
-import { InlineToken, LinkToken, ListToken, TokenItem } from '../../private/node/ui/components/TokenizedText.js';
+import { Token, InlineToken, LinkToken, ListToken, TokenItem } from '../../private/node/ui/components/TokenizedText.js';
 import { DangerousConfirmationPromptProps } from '../../private/node/ui/components/DangerousConfirmationPrompt.js';
 import { SelectPromptProps } from '../../private/node/ui/components/SelectPrompt.js';
 import { Task } from '../../private/node/ui/components/Tasks.js';
@@ -394,4 +394,4 @@ interface IsTTYOptions {
 export declare function isTTY({ stdin, uiDebugOptions }?: IsTTYOptions): boolean;
 export type Key = InkKey;
 export type InfoMessage = InfoMessageProps['message'];
-export { Task, TokenItem, InlineToken, LinkToken, TableColumn, InfoTableSection, ListToken, render, handleCtrlC };
\ No newline at end of file
+export { Token, Task, TokenItem, InlineToken, LinkToken, TableColumn, InfoTableSection, ListToken, render, handleCtrlC };
\ No newline at end of file

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.62% (+0.12% 🔼)
7913/10896
🟡 Branches
69.41% (+0.07% 🔼)
3886/5599
🟡 Functions
71.32% (+0.03% 🔼)
2076/2911
🟡 Lines
72.96% (+0.13% 🔼)
7478/10250

Test suite run success

1804 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from b07f196

@shauns shauns added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 92edac9 Aug 6, 2024
36 checks passed
@shauns shauns deleted the 1805-unactionable-error branch August 6, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants