Check organization beta flags for gated template specifications

[amcaplan]

WHY are these changes introduced?

Fills in a stubbed-out bit which is now made possible by @gracejychang's recent work connecting us to Business Platform!

WHAT is this pull request doing?

Rather than stubbing out feature flags, actually check for their presence!

How to test your changes?

1. Look at the list of extensions at https://github.com/Shopify/extensions-templates/blob/main/templates.json and pick a gated extension (marked by organizationBetaFlag).
2. Pointing to Spin, run app generate extension and note that the gated template doesn't appear.
3. Now, create the flag in business platform using the Maintenance::CreateFeatureFlagTask maintenance task.
4. The gated template still shouldn't appear.
5. Now, enable the flag on your organization.
6. Now the gated template appears in the list!

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/app-management

[github-actions]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	72.65% (+0.14% 🔼)	7922/10904
🟡	Branches	69.4% (+0.05% 🔼)	3887/5601
🟡	Functions	71.36% (+0.07% 🔼)	2081/2916
🟡	Lines	72.99% (+0.15% 🔼)	7487/10258

Show new covered files 🐣

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / organization_beta_flags.ts	100%	100%	100%	100%

Test suite run success

1808 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from fc2858d

[gonzaloriestra]

Great!

[gonzaloriestra]

I'm a bit confused. Why do we need two functions to run the query? Is this related to the PR?

[amcaplan]

The first function above uses classic manually typed schemas, while this function uses auto-generated types.

I do eventually need to learn more about the auto-generated stuff, but I think for this PR it's not relevant, as the GraphQL string is generated at runtime.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/business-platform.d.ts

@@ -24,10 +24,20 @@ export declare function businessPlatformRequestDoc<TResult, TVariables extends V
  *
  * @param query - GraphQL query to execute.
  * @param token - Business Platform token.
+ * @param organizationId - Organization ID as a numeric (non-GID) value.
+ * @param variables - GraphQL variables to pass to the query.
+ * @returns The response of the query of generic type <T>.
+ */
+export declare function businessPlatformOrganizationsRequest<T>(query: string, token: string, organizationId: string, variables?: GraphQLVariables): Promise<T>;
+/**
+ * Executes a GraphQL query against the Business Platform Organizations API. Uses typed documents.
+ *
+ * @param query - GraphQL query to execute.
+ * @param token - Business Platform token.
  * @param organizationId - Organization ID as a numeric value.
  * @param variables - GraphQL variables to pass to the query.
  * @returns The response of the query of generic type <T>.
  */
-export declare function businessPlatformOrganizationsRequest<TResult>(query: TypedDocumentNode<TResult, GraphQLVariables> | TypedDocumentNode<TResult, Exact<{
+export declare function businessPlatformOrganizationsRequestDoc<TResult>(query: TypedDocumentNode<TResult, GraphQLVariables> | TypedDocumentNode<TResult, Exact<{
     [key: string]: never;
 }>>, token: string, organizationId: string, variables?: GraphQLVariables): Promise<TResult>;
\ No newline at end of file