[Themes] - Shopify Theme Console

[jamesmengo]

WHY are these changes introduced?

• https://github.com/orgs/Shopify/projects/4613/views/62?pane=issue&itemId=69671709

WHAT is this pull request doing?

Base branch for the shopify theme console TS implementation

How to test your changes?

• There are more detailed instructions in each of the feature branches that were merged in

1. Execute the new feature pnpm shopify theme console --dev-preview
2. Open an instance of the ruby implementation shopify theme console

Evaluate some expressions and look for parity differences

Intentional Differences:

• We return null rather than nil in TS land

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/app-management

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	72.61% (+0.08% 🔼)	7912/10896
🟡	Branches	69.39% (+0.05% 🔼)	3885/5599
🟡	Functions	71.32% (-0.02% 🔻)	2076/2911
🟡	Lines	72.95% (+0.09% 🔼)	7477/10250

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / common.ts	87.5%	44.44%	75% (-5% 🔻)	87.5%
🟢	... / common.ts	87.5% (-1.39% 🔻)	88.89%	100%	100%
🟢	... / usePollAppLogs.ts	93.18% (-0.15% 🔻)	95.24% (-0.41% 🔻)	80% (-1.82% 🔻)	93.02%
🔴	... / app-management-client.ts	17.54% (-2.02% 🔻)	11.11%	17.39% (-2.17% 🔻)	15.38% (-2.23% 🔻)

Test suite run success

1804 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from ddbe9f5

[karreiro]

Thank you, @jamesmengo! Awesome stuff! 🔥 I've left only some minor comments :)

[karreiro]

Thank you for this PR, @jamesmengo! Great stuff. I've left some comments, but the PR looks great, and I could not find any bugs 🚀

Besides the comments, I believe we could:

• rename evaluater.ts to evaluator.ts
• move repl-theme-manager.ts and password-prompt.ts to the packages/theme/src/cli/utilities/repl/ directory

What do you think?

Thanks again for this PR! :)

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/http.d.ts

@@ -7,7 +7,7 @@ export { FetchError, Request } from 'node-fetch';
  * @returns A FormData object.
  */
 export declare function formData(): FormData;
-export type Response = ReturnType<typeof nodeFetch>;
+export type Response = Awaited<ReturnType<typeof nodeFetch>>;
 /**
  * An interface that abstracts way node-fetch. When Node has built-in
  * support for "fetch" in the standard library, we can drop the node-fetch
@@ -20,7 +20,7 @@ export type Response = ReturnType<typeof nodeFetch>;
  * @param init - An object containing any custom settings that you want to apply to the request.
  * @returns A promise that resolves with the response.
  */
-export declare function fetch(url: RequestInfo, init?: RequestInit): Response;
+export declare function fetch(url: RequestInfo, init?: RequestInit): Promise<Response>;
 /**
  * A fetch function to use with Shopify services. The function ensures the right
  * TLS configuragion is used based on the environment in which the service is running
@@ -30,7 +30,7 @@ export declare function fetch(url: RequestInfo, init?: RequestInit): Response;
  * @param init - An object containing any custom settings that you want to apply to the request.
  * @returns A promise that resolves with the response.
  */
-export declare function shopifyFetch(url: RequestInfo, init?: RequestInit): Response;
+export declare function shopifyFetch(url: RequestInfo, init?: RequestInit): Promise<Response>;
 /**
  * Download a file from a URL to a local path.
  *

[karreiro]

Thank you, @jamesmengo! 🔥🚀