Add make module. #18
Merged
Add make module. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shatur
requested changes
Nov 29, 2023
Supports dynamic tasks, mapped to make targets, by default.
undyamon
force-pushed
the
feat-make-module
branch
from
444e150
to
43114ec
Compare
|
Could you also fix formatting, please? |
|
Sure what do you use to format Lua code? |
|
Stylua, but you could just apply diff from the failed job to avoid installing a new tool. |
|
Looks like still fails due to an extra newline. |
undyamon
force-pushed
the
feat-make-module
branch
from
c17e7ef
to
4cfaeb9
Compare
|
bruh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports dynamic tasks, mapped to make targets by default.
Closes #16