Meta: Build system overhaul #1057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandMC
commented
May 13, 2024
CommandMC
force-pushed
the
build-system-overhaul
branch
3 times, most recently
from
9c8d6da
to
9c881c3
Compare
bgianfo
requested changes
May 17, 2024
There was a problem hiding this comment.
I think you also need to update:
- https://github.com/SerenityOS/discord-bot/blob/master/.pre-commit-config.yaml#L30
- https://github.com/SerenityOS/discord-bot/blob/master/Procfile (maybe
npm startjust works?) - Does dependabot support
pnmplock files? https://github.com/SerenityOS/discord-bot/blob/master/.github/dependabot.yml#L4
|
esbuild has built-in TypeScript support (so no more ts-node required) and allows us to use any Node version (as it transforms newer JS features into older syntax) It is also just a great deal faster than tsc
Just like esbuild, Vitest supports TypeScript out of the box, which means we can completely get rid of ts-node
Yarn 1, what the project used before, has been deprecated for a while. Updating to Yarn Berry (4) would be possible, but it is not that widespread yet. pnpm is another alternative package manager which many projects have now switched to. It is a lot faster than yarn, and offers safer dependency management
CommandMC
force-pushed
the
build-system-overhaul
branch
from
9c881c3
to
67dbfef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing a lot of things back up to the latest and greatest in JS land
Performance differences (measured on a rather old Thinkpad T430, so your times will probably be faster):
(yarn,pnpm) install): 17.46s -> 2.4sbuildscript): 6.9s -> 11mstestscript): 6.34s -> 1.56s