[Fix] Item Display rotations incorrect in versions after 1.19.4 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAHuman-xD
commented
Mar 5, 2024
src/main/java/dev/sefiraat/cultivation/implementation/utils/Transformations.java
Outdated
Show resolved
Hide resolved
Sefiraat
reviewed
Mar 5, 2024
src/main/java/dev/sefiraat/cultivation/implementation/utils/Utils.java
Outdated
Show resolved
Hide resolved
ybw0014
reviewed
Mar 5, 2024
src/main/java/dev/sefiraat/cultivation/implementation/utils/GeneralUtils.java
Outdated
Show resolved
Hide resolved
|
I'll need to test this to make sure it works as intended as I haven't used paperlib like this before. According to the javadocs this should be what I want but who knows 🤷♂️ |
|
Latest changes have been tested & confirmed to work on 1.20.4 I'll work on testing other versions later today/this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.20 and on Item Displays are rotated 180 degrees on the Y axis, this PR makes cultivation automatically correct its models when on a server of those versions. it also applies a base transformation to the cultivation plant so that it can be corrected as well.