Fix for bad git path in GHA macos instances. #464
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
trexfeathers
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From testing problems in #458 and #460, there is an odd problem with GHA macos instances
(this might also indicate that the root problem may soon get a fix?)
In detail, it seems that the latest-good git installation is not (?always?) put on the front of the path when your GHA runs,
but instead an older system git runs by default. Which, possibly, does not have a "git version" command ?
So, for now, this hack pushes a magic directory onto the front of PATH to make the tests run.
(N.B. wheels are OK and unaffected. The problem occurs when doing an editable install of the repo)