Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing pre-commit checks #999

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

aphedges
Copy link
Contributor

@aphedges aphedges commented Aug 28, 2024

CI hasn't been running properly, so it didn't catch these failures.


🚀 This description was created by Ellipsis for commit 592a2d3

Summary:

Fixes pre-commit check failures by adjusting formatting and string delimiters in py/cli/utils/docker_utils.py, py/core/configs/local_llm_neo4j_kg.toml, and py/tests/test_kg.py.

Key points:

  • Added newline in py/cli/utils/docker_utils.py after set_config_env_vars function.
  • Ensured consistent string delimiter usage in py/tests/test_kg.py for entity name assertion.
  • Removed unnecessary newline at end of file in py/core/configs/local_llm_neo4j_kg.toml.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 592a2d3 in 16 seconds

More details
  • Looked at 48 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/configs/local_llm_neo4j_kg.toml:53
  • Draft comment:
    Unnecessary newline at the end of the file. Please remove it to adhere to style guidelines.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR description indicates that the changes are meant to fix pre-commit checks. The changes in the test file involve replacing single quotes with double quotes, which is a common style guide requirement. However, there is an extra newline added at the end of the file, which is unnecessary and should be removed.

Workflow ID: wflow_V4MlSBhcwfOJmRG0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty merged commit 76c1f88 into SciPhi-AI:main Aug 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants